refactor(integration): migrate to IExecutor interface#255
Merged
Conversation
Add new executor integration infrastructure using common_system's IExecutor interface instead of direct thread_system dependency. This provides: - standalone_executor: IExecutor implementation using std::jthread - executor_integration: Manager class for runtime executor injection - Updated thread_integration_detector.h with IExecutor detection Benefits: - No compile-time dependency on thread_system - Runtime executor injection for flexibility - Better testability with mock executors Implements part of #253
Add comprehensive unit tests for the new IExecutor-based integration: - Basic state tests (enable, disable, executor type) - Task submission tests (sync, async, delayed) - standalone_executor tests (basic, job execution, factory) - Thread safety tests (concurrent state checks, task submission) - Metrics tests (pending_tasks, worker_count) All 16 tests pass successfully. Part of #253
Update THREAD_SYSTEM.md to include: - IExecutor interface integration overview - executor_integration API reference - standalone_executor documentation - Migration guide from thread_system_integration - Updated related documentation links Part of #253
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* feat(integration): add IExecutor-based async integration layer Add new executor integration infrastructure using common_system's IExecutor interface instead of direct thread_system dependency. This provides: - standalone_executor: IExecutor implementation using std::jthread - executor_integration: Manager class for runtime executor injection - Updated thread_integration_detector.h with IExecutor detection Benefits: - No compile-time dependency on thread_system - Runtime executor injection for flexibility - Better testability with mock executors Implements part of #253 * test(integration): add unit tests for executor_integration Add comprehensive unit tests for the new IExecutor-based integration: - Basic state tests (enable, disable, executor type) - Task submission tests (sync, async, delayed) - standalone_executor tests (basic, job execution, factory) - Thread safety tests (concurrent state checks, task submission) - Metrics tests (pending_tasks, worker_count) All 16 tests pass successfully. Part of #253 * docs(integration): add IExecutor integration documentation Update THREAD_SYSTEM.md to include: - IExecutor interface integration overview - executor_integration API reference - standalone_executor documentation - Migration guide from thread_system_integration - Updated related documentation links Part of #253
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
New Files
include/kcenon/logger/integration/executor_integration.h- IExecutor-based integration managerinclude/kcenon/logger/integration/standalone_executor.h- Standalone IExecutor implementationsrc/integration/executor_integration.cpp- executor_integration implementationsrc/integration/standalone_executor.cpp- standalone_executor implementationtests/unit/executor_integration_test.cpp- Unit tests for executor_integrationModified Files
include/kcenon/logger/core/thread_integration_detector.h- Added IExecutor detectiondocs/integration/THREAD_SYSTEM.md- Updated with IExecutor documentationtests/CMakeLists.txt- Added executor_integration_testTest plan
Benefits
Closes #253