refactor: migrate from deprecated common_system APIs before v3.0.0#249
Merged
Merged
Conversation
- Add source_location-based log() method to common_system_logger_adapter - Update deprecated log() method with explicit file/line/function to delegate to new source_location-based implementation - Redirect THREAD_LOG_* macros to common_system's LOG_* macros - Suppress deprecation warnings in backward compatibility tests Closes #248
Add documentation for Issue #248: - Document source_location-based logging API changes - Add migration guide for THREAD_LOG_* to LOG_* macros - Add migration guide for ILogger implementations
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
) * refactor: migrate to source_location-based logging API - Add source_location-based log() method to common_system_logger_adapter - Update deprecated log() method with explicit file/line/function to delegate to new source_location-based implementation - Redirect THREAD_LOG_* macros to common_system's LOG_* macros - Suppress deprecation warnings in backward compatibility tests Closes #248 * docs: update CHANGELOG for deprecated API migration Add documentation for Issue #248: - Document source_location-based logging API changes - Add migration guide for THREAD_LOG_* to LOG_* macros - Add migration guide for ILogger implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log()method to common_system_logger_adapterlog()method with explicit file/line/function to delegate to new source_location-based implementationChanges
common_system_adapter.h
log(log_level, std::string_view, const source_location&)overridelog(log_level, string, file, line, function)now delegates to new APIsource_location.hincludelogger_interface.h
Tests
ilogger_interface_test.cppfor backward compatibility testingTest Plan
Related Issues
Closes #248