chore(cmake): Standardize namespace to snake_case (DatabaseSystem:: → database_system::)#465
Merged
Merged
Conversation
… database_system::) Adopt ecosystem convention of <name>:: snake_case namespace. Add backward compatibility aliases for DatabaseSystem:: consumers. Closes #464
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatabaseSystem::todatabase_system::to adopt the ecosystem convention of<name>::snake_case namespacingDatabaseSystem::database,DatabaseSystem::integrated_database) so existing consumers continue to work without changesWhat
CMakeLists.txtNAMESPACE DatabaseSystem::→NAMESPACE database_system::(install + build-tree export)cmake/database_system-config.cmake.inadd_library(ALIAS)for backward compat.github/workflows/vcpkg-overlay.ymltarget_link_librariesin find_package verification testREADME.md/README.kr.mdWhy
Standardize on snake_case namespace (
database_system::) to match the ecosystem convention used across sibling projects.Part of kcenon/common_system#456
Closes #464
Test plan
DatabaseSystem::databasecontinue to work via backward compatibility aliases