fix(cmake): change find_dependency from QUIET to REQUIRED for mandatory deps#463
Merged
Merged
Conversation
…ry deps common_system is a hard requirement (CMakeLists.txt enforces FATAL_ERROR if not found), but the installed config template used QUIET, silently proceeding when the dependency was missing. This caused consumers to get cryptic linker errors instead of a clear configure-time failure. Also change container_system to REQUIRED within its USE_CONTAINER_SYSTEM guard, since the guard already implies the dependency is expected. Closes #462
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
…ry deps (#463) common_system is a hard requirement (CMakeLists.txt enforces FATAL_ERROR if not found), but the installed config template used QUIET, silently proceeding when the dependency was missing. This caused consumers to get cryptic linker errors instead of a clear configure-time failure. Also change container_system to REQUIRED within its USE_CONTAINER_SYSTEM guard, since the guard already implies the dependency is expected. Closes #462
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Summary
Changes
find_dependency(common_system CONFIG QUIET)toREQUIREDin the installed config template, and similarly forcontainer_systemwithin itsUSE_CONTAINER_SYSTEMguard. This aligns the installed config's dependency requirements with the build-timeFATAL_ERRORenforcement.Change Type
Why
Related Issues
Motivation
common_systemis mandatory at build time (FATAL_ERRORif missing), but the installed config template usedQUIET, silently proceeding when the dependency was absent. Consumers would then get cryptic linker errors instead of a clear configure-time "common_system not found" message.Where
Files Changed
cmake/database_system-config.cmake.inQUIET→REQUIREDforcommon_systemandcontainer_systemHow
Implementation
find_dependency(common_system CONFIG QUIET)→find_dependency(common_system CONFIG REQUIRED)find_dependency(container_system CONFIG QUIET)→find_dependency(container_system CONFIG REQUIRED)(withinUSE_CONTAINER_SYSTEMguard)Test Plan
find_package(database_system CONFIG)should fail immediately with a clear error whencommon_systemis not installed