refactor(core): remove deprecation.h for C++20 module preparation#223
Merged
Conversation
Remove deprecated warning suppression macros and consolidate deprecation handling to use standard [[deprecated]] attribute. Changes: - Remove core/deprecation.h file - Remove CONTAINER_SUPPRESS_DEPRECATION_START/END macros from test files - Remove deprecated wrapper functions (IsCiEnvironment, AdjustPerformanceThreshold, AdjustDurationThreshold) that were already marked deprecated and had no callers This simplifies the codebase following Kent Beck's "Fewest Elements" principle and prepares for C++20 module migration. Closes #221
Update both English and Korean changelogs with details about the deprecation.h removal and C++20 module preparation changes.
Contributor
Performance Benchmark ReportSummary
✅ Status: No significant performance regressions detected. |
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* refactor(core): remove deprecation.h for C++20 module preparation Remove deprecated warning suppression macros and consolidate deprecation handling to use standard [[deprecated]] attribute. Changes: - Remove core/deprecation.h file - Remove CONTAINER_SUPPRESS_DEPRECATION_START/END macros from test files - Remove deprecated wrapper functions (IsCiEnvironment, AdjustPerformanceThreshold, AdjustDurationThreshold) that were already marked deprecated and had no callers This simplifies the codebase following Kent Beck's "Fewest Elements" principle and prepares for C++20 module migration. Closes #221 * docs(changelog): add deprecation.h removal entry Update both English and Korean changelogs with details about the deprecation.h removal and C++20 module preparation changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core/deprecation.hfile with custom warning suppression macrosCONTAINER_SUPPRESS_DEPRECATION_START/ENDmacros from test framework filesIsCiEnvironment,AdjustPerformanceThreshold,AdjustDurationThreshold)[[deprecated]]attribute instead of custom macrosChanges
Removed Files
core/deprecation.h- Custom deprecation warning suppression macrosModified Files
integration_tests/framework/test_helpers.h- Remove include and macros, remove deprecated functionsintegration_tests/framework/system_fixture.h- Remove include and macrosTest plan
[[deprecated]]attribute)Closes #221