Use KCENON_HAS_COMMON_SYSTEM in container core#181
Merged
Conversation
…STEM - Replace CONTAINER_USE_COMMON_SYSTEM and BUILD_WITH_COMMON_SYSTEM checks with unified KCENON_HAS_COMMON_SYSTEM macro - Include feature_flags.h from common_system in container core headers - Update CMakeLists.txt to define KCENON_HAS_COMMON_SYSTEM=1 - Maintain backward compatibility with existing CMake options Closes #180
- Update EXCEPTION_SAFETY.md with new macro name - Update STRUCTURE.md to reflect KCENON_HAS_COMMON_SYSTEM usage - Update INTEGRATION.md build configuration section
Contributor
Performance Benchmark ReportSummary
✅ Status: No significant performance regressions detected. |
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* refactor: normalize common_system integration to KCENON_HAS_COMMON_SYSTEM - Replace CONTAINER_USE_COMMON_SYSTEM and BUILD_WITH_COMMON_SYSTEM checks with unified KCENON_HAS_COMMON_SYSTEM macro - Include feature_flags.h from common_system in container core headers - Update CMakeLists.txt to define KCENON_HAS_COMMON_SYSTEM=1 - Maintain backward compatibility with existing CMake options Closes #180 * docs: update documentation to reference KCENON_HAS_COMMON_SYSTEM - Update EXCEPTION_SAFETY.md with new macro name - Update STRUCTURE.md to reflect KCENON_HAS_COMMON_SYSTEM usage - Update INTEGRATION.md build configuration section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTAINER_USE_COMMON_SYSTEMandBUILD_WITH_COMMON_SYSTEMcode checks with unifiedKCENON_HAS_COMMON_SYSTEMmacrofeature_flags.hfrom common_system in container core headersParent Issue
kcenon/common_system#223
Changes
Source Files
CMakeLists.txt: DefineKCENON_HAS_COMMON_SYSTEM=1instead ofCONTAINER_USE_COMMON_SYSTEMcore/container.h: Includefeature_flags.h, replace macro checkscore/container.cpp: Replace macro checkskcenon/container/di/service_registration.h: Includefeature_flags.h, replace macro checksDocumentation
docs/advanced/EXCEPTION_SAFETY.md: Update code examplesdocs/advanced/STRUCTURE.md: Update macro referencesdocs/guides/INTEGRATION.md: Update build configuration sectionTest Plan
Closes #180