Skip to content

fix: CI/CD workflow issues for header-only library#6

Merged
kcenon merged 17 commits into
mainfrom
fix/ci-workflow
Sep 25, 2025
Merged

fix: CI/CD workflow issues for header-only library#6
kcenon merged 17 commits into
mainfrom
fix/ci-workflow

Conversation

@kcenon

@kcenon kcenon commented Sep 25, 2025

Copy link
Copy Markdown
Owner

Summary

  • Fixed CI/CD workflow failures by making test dependencies optional
  • Improved build performance with vcpkg caching
  • Fixed missing headers in example code

Changes

  • CMakeLists.txt: Made GTest optional for header-only library builds
  • tests/CMakeLists.txt: Added conditional GTest inclusion
  • examples/executor_example.cpp: Added missing <queue>, <mutex>, <condition_variable> headers
  • Ubuntu workflows: Added vcpkg caching, made tests conditional on GTest availability
  • Windows workflows: Disabled tests where dependencies are unavailable

Test Plan

  • Local build tested successfully
  • Examples run without errors
  • CI/CD workflows should pass on all platforms
  • Verify header-only mode works correctly

Related Issues

Fixes initial CI/CD setup issues for the new common_system repository.

dependabot Bot and others added 6 commits September 25, 2025 09:26
Bumps [microsoft/setup-msbuild](https://github.com/microsoft/setup-msbuild) from 1.1 to 1.3.
- [Release notes](https://github.com/microsoft/setup-msbuild/releases)
- [Changelog](https://github.com/microsoft/setup-msbuild/blob/main/building-release.md)
- [Commits](microsoft/setup-msbuild@v1.1...v1.3)

---
updated-dependencies:
- dependency-name: microsoft/setup-msbuild
  dependency-version: '1.3'
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3 to 4.
- [Release notes](https://github.com/peaceiris/actions-gh-pages/releases)
- [Changelog](https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md)
- [Commits](peaceiris/actions-gh-pages@v3...v4)

---
updated-dependencies:
- dependency-name: peaceiris/actions-gh-pages
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2.
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](softprops/action-gh-release@v1...v2)

---
updated-dependencies:
- dependency-name: softprops/action-gh-release
  dependency-version: '2'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
- Make test dependencies optional in CMakeLists.txt
- Disable tests in Windows builds where dependencies are unavailable
- Add vcpkg caching to Ubuntu workflows for better performance
- Fix missing headers in executor example
- Adjust CMake configurations for header-only mode
@github-advanced-security

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@kcenon

kcenon commented Sep 25, 2025

Copy link
Copy Markdown
Owner Author

Consolidation: merged Dependabot workflow updates (#1#5) into this branch. Closing those PRs as superseded by this one. Also fixed header include (removed accidental CMake include) so CI build can proceed.

… CodeQL and misc CI pipeline\n- Restrict builds to main branch only\n- Keep 4 build jobs + Doxygen, aligned with thread/logger/monitoring/container/database/network
…y Ubuntu-Clang/GCC to single Debug c++17 build\n- Simplify Windows VS/MSYS2 to x64 Debug c++17\n- Remove vcpkg and version matrices; keep example compile test
@kcenon kcenon merged commit 023ecd8 into main Sep 25, 2025
5 checks passed
@kcenon kcenon deleted the fix/ci-workflow branch September 25, 2025 10:51
kcenon added a commit that referenced this pull request Apr 13, 2026
* build(deps): bump microsoft/setup-msbuild from 1.1 to 1.3

Bumps [microsoft/setup-msbuild](https://github.com/microsoft/setup-msbuild) from 1.1 to 1.3.
- [Release notes](https://github.com/microsoft/setup-msbuild/releases)
- [Changelog](https://github.com/microsoft/setup-msbuild/blob/main/building-release.md)
- [Commits](microsoft/setup-msbuild@v1.1...v1.3)

---
updated-dependencies:
- dependency-name: microsoft/setup-msbuild
  dependency-version: '1.3'
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump peaceiris/actions-gh-pages from 3 to 4

Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3 to 4.
- [Release notes](https://github.com/peaceiris/actions-gh-pages/releases)
- [Changelog](https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md)
- [Commits](peaceiris/actions-gh-pages@v3...v4)

---
updated-dependencies:
- dependency-name: peaceiris/actions-gh-pages
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/checkout from 3 to 5

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump softprops/action-gh-release from 1 to 2

Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2.
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](softprops/action-gh-release@v1...v2)

---
updated-dependencies:
- dependency-name: softprops/action-gh-release
  dependency-version: '2'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: CI/CD workflow issues for header-only library

- Make test dependencies optional in CMakeLists.txt
- Disable tests in Windows builds where dependencies are unavailable
- Add vcpkg caching to Ubuntu workflows for better performance
- Fix missing headers in executor example
- Adjust CMake configurations for header-only mode

* fix(headers): remove invalid CMake include from header

* build(vcpkg): set valid builtin-baseline for vcpkg manifest

* chore(ci): simplify workflows to match other system repos\n\n- Remove CodeQL and misc CI pipeline\n- Restrict builds to main branch only\n- Keep 4 build jobs + Doxygen, aligned with thread/logger/monitoring/container/database/network

* chore(ci): one workflow per OS+compiler without matrices\n\n- Simplify Ubuntu-Clang/GCC to single Debug c++17 build\n- Simplify Windows VS/MSYS2 to x64 Debug c++17\n- Remove vcpkg and version matrices; keep example compile test

* ci(windows-vs): add MSVC dev-cmd for cl availability in example compile step

* fix(headers): add missing includes in event_bus (string, chrono, cstdint)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants