chore(ci): Graduate sanitizer jobs from Phase 0 to Phase 1#396
Merged
Conversation
Remove || true from sanitizer ctest commands so sanitizer failures now block merges instead of being silently ignored. Refs: #394
3 tasks
Add suppression file for known data race in config_watcher inotify fd access between cleanup and watch threads. Follow-up fix tracked in #397
5 tasks
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* chore(ci): graduate sanitizer jobs from Phase 0 to Phase 1 Remove || true from sanitizer ctest commands so sanitizer failures now block merges instead of being silently ignored. Refs: #394 * chore(ci): add TSan suppression for config_watcher data race Add suppression file for known data race in config_watcher inotify fd access between cleanup and watch threads. Follow-up fix tracked in #397
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
|| truefrom the sanitizerctestinvocationTSAN_OPTIONSwith a repository suppression file so the knownconfig_watcherLinux race does not prevent the broader Phase 1 rolloutChanges
.github/workflows/ci.yml: sanitizer test failures now fail the GitHub Actions job instead of being ignored.github/workflows/ci.yml: ThreadSanitizer runs withhalt_on_error=1andsanitizers/tsan_suppressions.txtsanitizers/tsan_suppressions.txt: add temporary suppressions for the knownconfig_watcherinotify fd race tracked in fix(config): Data race in config_watcher inotify fd access #397Why this shape
config_watcherrace would make TSan fail immediately on every runVerification
config_watcherrace tracked in fix(config): Data race in config_watcher inotify fd access #397Refs #394