Remove deprecated file/line/function log() method from ILogger#225
Merged
Conversation
Remove the deprecated ILogger::log() method that accepted file, line, and function parameters separately. This method was deprecated in v2.0.0 and is now removed as planned for v3.0.0. The source_location-based log() method remains as the preferred approach, automatically capturing source location at the call site. Breaking change: - Custom ILogger implementations must remove their override of the deprecated log(level, message, file, line, function) method. Closes #217
Update all test logger implementations to remove the deprecated file/line/function log() method override, now that the method has been removed from the ILogger interface. Test loggers now only override: - log(level, message) - log(level, string_view, source_location) - log(log_entry) All 105 tests pass with the updated implementations.
- DEPRECATION.md/KO: Move file/line/function log() from deprecated to removed section, update migration guides - CHANGELOG.md/KO: Add breaking change entry for v3.0.0 API removal - API_REFERENCE.md/KO: Remove deprecated method from interface docs, update usage examples See migration guide in docs/DEPRECATION.md for updating custom ILogger implementations.
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* refactor(logger): remove deprecated file/line/function log() method Remove the deprecated ILogger::log() method that accepted file, line, and function parameters separately. This method was deprecated in v2.0.0 and is now removed as planned for v3.0.0. The source_location-based log() method remains as the preferred approach, automatically capturing source location at the call site. Breaking change: - Custom ILogger implementations must remove their override of the deprecated log(level, message, file, line, function) method. Closes #217 * test(logger): update test logger implementations for v3.0.0 Update all test logger implementations to remove the deprecated file/line/function log() method override, now that the method has been removed from the ILogger interface. Test loggers now only override: - log(level, message) - log(level, string_view, source_location) - log(log_entry) All 105 tests pass with the updated implementations. * docs: update documentation for deprecated API removal - DEPRECATION.md/KO: Move file/line/function log() from deprecated to removed section, update migration guides - CHANGELOG.md/KO: Add breaking change entry for v3.0.0 API removal - API_REFERENCE.md/KO: Remove deprecated method from interface docs, update usage examples See migration guide in docs/DEPRECATION.md for updating custom ILogger implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ILogger::log(level, message, file, line, function)method that was deprecated in v2.0.0Breaking Change
Custom
ILoggerimplementations must remove their override of the deprecated method:Use the source_location-based method instead:
Changes
logger_interface.h: Removed deprecated method, updated default implementationglobal_logger_registry.h: Removed deprecated method from NullLoggerTest Plan
Closes #217