Phase 2: Interface Unification (Logger & Executor)#12
Merged
Conversation
- Add logger_config structure for advanced logger configuration - Add ILoggerRegistry interface for named logger management - Enhance from_string() to support case-insensitive parsing - Add support for WARN and FATAL aliases Phase 2 Task 2.1.1: Logger Interface Unification
- Add IJob interface for better task control and testability - Add execute() and execute_delayed() methods with Result<T> returns - Keep legacy submit() methods for backward compatibility - Add job priority and naming support Phase 2 Task 2.2.1: Executor Interface Unification
- Mark Logger Interface Unification as completed - Mark Executor Interface Unification as completed - Update critical issues overview - Document Phase 2 partial completion status
This was referenced Oct 2, 2025
…utor - Add job-based execution methods to satisfy IExecutor interface - Add calculation_job example class implementing IJob - Add Example 7 demonstrating job-based execution - Fixes CI build errors (abstract class instantiation) Resolves: executor_example.cpp compilation errors
- Use is_ok(), is_error(), get_value(), get_error() helpers - Convert unique_ptr to shared_ptr for lambda capture - Fixes copy-constructible requirement for std::function - Fixes operator! and .error() usage on Result<T> Resolves: CI compilation errors with Result<T> API
This was referenced Dec 1, 2025
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* feat(phase2): extend ILogger interface with ILoggerRegistry - Add logger_config structure for advanced logger configuration - Add ILoggerRegistry interface for named logger management - Enhance from_string() to support case-insensitive parsing - Add support for WARN and FATAL aliases Phase 2 Task 2.1.1: Logger Interface Unification * feat(phase2): extend IExecutor with job-based execution - Add IJob interface for better task control and testability - Add execute() and execute_delayed() methods with Result<T> returns - Keep legacy submit() methods for backward compatibility - Add job priority and naming support Phase 2 Task 2.2.1: Executor Interface Unification * docs(phase2): update NEED_TO_FIX.md with Task 2.1 & 2.2 completion - Mark Logger Interface Unification as completed - Mark Executor Interface Unification as completed - Update critical issues overview - Document Phase 2 partial completion status * fix(examples): implement execute() and execute_delayed() in mock_executor - Add job-based execution methods to satisfy IExecutor interface - Add calculation_job example class implementing IJob - Add Example 7 demonstrating job-based execution - Fixes CI build errors (abstract class instantiation) Resolves: executor_example.cpp compilation errors * fix(examples): use Result<T> helper functions correctly - Use is_ok(), is_error(), get_value(), get_error() helpers - Convert unique_ptr to shared_ptr for lambda capture - Fixes copy-constructible requirement for std::function - Fixes operator! and .error() usage on Result<T> Resolves: CI compilation errors with Result<T> API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 Interface Unification - Part 1 (Logger & Executor)
This PR implements Task 2.1 and Task 2.2 of Phase 2, unifying logger and executor interfaces across all systems.
Changes
Task 2.1: Logger Interface Unification
ILoggerinterface withILoggerRegistryfor named logger managementlogger_configstructure for advanced configurationfrom_string()with case-insensitive parsingTask 2.2: Executor Interface Unification
IJobinterface for better task control and testabilityIExecutorwith job-based execution methodsexecute()andexecute_delayed()withResult<std::future<void>>returnssubmit()methodsImpact
Testing
Documentation
Related PRs