integration/docker: unskip docer cp test#971
integration/docker: unskip docer cp test#971grahamwhaley merged 1 commit intokata-containers:masterfrom
Conversation
|
/test |
|
lgtm |
|
lgtm |
|
Looks like the metrics CI result has been zapped. I can't see how to re-test just this PR under the metrics CI. /cc @devimc, @grahamwhaley. |
|
yep, that is because the last run was too long ago, and our Jenkins server expires old logs and jobs (I don't remember the rate - it may only keep job history for a week). /test |
Unskip docker cp test to check mount points are not left after running docker cp. Depends-on: github.com/kata-containers/runtime#980 fixes kata-containers#970 Signed-off-by: Julio Montes <julio.montes@intel.com>
41c8d87 to
d431cdb
Compare
When overlay is used as storage driver, kata runtime creates a new bind mount point to the merged directory, that way this directory can be shared with the VM through 9p. By default the mount propagation is shared, that means mount events are propagated, but umount events not, to deal with this problem and to avoid left mount points in the host once container finishes, the mount propagation of bind mounts should be set to private. Depends-on: github.com/kata-containers/tests#971 fixes kata-containers#794 Signed-off-by: Julio Montes <julio.montes@intel.com>
|
/test |
When overlay is used as storage driver, kata runtime creates a new bind mount point to the merged directory, that way this directory can be shared with the VM through 9p. By default the mount propagation is shared, that means mount events are propagated, but umount events not, to deal with this problem and to avoid left mount points in the host once container finishes, the mount propagation of bind mounts should be set to private. Depends-on: github.com/kata-containers/tests#971 fixes kata-containers#794 Signed-off-by: Julio Montes <julio.montes@intel.com>
|
/test |
|
Ping @devimc - this still has a dnm label - should it have that? |
|
@jodh-intel nop, removing dnm label, thanks |
|
Thanks @devimc. Ping @kata-containers/tests for more reviews. |
Unskip docker cp test to check mount points are not left
after running docker cp.
Depends-on: github.com/kata-containers/runtime#980
fixes #970
Signed-off-by: Julio Montes julio.montes@intel.com