ci: make sure template mountpoints are cleaned up#761
ci: make sure template mountpoints are cleaned up#761bergwolf wants to merge 1 commit intokata-containers:masterfrom
Conversation
Since we relay on the mountpoints to check for test results, let's make sure it is cleaned up before and after the tests. Fixes: kata-containers#760 Signed-off-by: Peng Tao <bergwolf@gmail.com>
|
ping @jodh-intel @grahamwhaley. This is blocking all the runtime repo PRs. |
|
I can see the principle, to clean up before we run the test (and iirc, we do that for processes with some kill_all_processes() in the metrics and maybe QA tests), but, this is also hiding the problem that somebody seems to be leaving those mount points behind in the first place.... I'm prone to say - this patch is fine, but we should identify who left the mounts around in the first place, and have either a check or a BUG and/or Issue for that - ideally before we merge this (or we'll forget ;-) ). |
|
@grahamwhaley Fair enough. You've beaten me to it :) See kata-containers/runtime#764 |
|
Let's close this one and let it catch future leaks if possible. |
Since we relay on the mountpoints to check for test results,
let's make sure it is cleaned up before and after the tests.
Fixes: #760