Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Cleanup template properly#764

Merged
amshinde merged 2 commits intokata-containers:masterfrom
bergwolf:cleanup-template
Sep 20, 2018
Merged

Cleanup template properly#764
amshinde merged 2 commits intokata-containers:masterfrom
bergwolf:cleanup-template

Conversation

@bergwolf
Copy link
Copy Markdown
Member

@bergwolf bergwolf commented Sep 20, 2018

As CI has found out by running the UTs, we are not cleaning up vm factory properly in error path. Also the UTs need to close factory properly so that we do not leave the template mountpoint behind.

@bergwolf
template: clean up template mountpoint on failures
b193f0f 
So that we don't leave it behind.

Signed-off-by: Peng Tao <bergwolf@gmail.com>
@bergwolf bergwolf mentioned this pull request Sep 20, 2018
Closed
grahamwhaley
grahamwhaley approved these changes Sep 20, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thx!

@grahamwhaley
Copy link
Copy Markdown
Contributor

grahamwhaley commented Sep 20, 2018

Related to kata-containers/tests#761

@katacontainersbot
Copy link
Copy Markdown
Contributor

katacontainersbot commented Sep 20, 2018

PSS Measurement:
Qemu: 165675 KB
Proxy: 4207 KB
Shim: 8764 KB

Memory inside container:
Total Memory: 2043460 KB
Free Memory: 2006704 KB

@bergwolf
factory: close factory in UT
67ffa2f 
So that we do not leave artifacts like template mountpoint
behind.

Fixes: kata-containers#763

Signed-off-by: Peng Tao <bergwolf@gmail.com>
@katacontainersbot
Copy link
Copy Markdown
Contributor

katacontainersbot commented Sep 20, 2018

PSS Measurement:
Qemu: 165696 KB
Proxy: 4107 KB
Shim: 8740 KB

Memory inside container:
Total Memory: 2043460 KB
Free Memory: 2006588 KB

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@76b0c3c). Click here to learn what that means.
The diff coverage is 71.42%.

@@            Coverage Diff            @@
##             master     #764   +/-   ##
=========================================
  Coverage          ?   65.29%           
=========================================
  Files             ?       87           
  Lines             ?    10570           
  Branches          ?        0           
=========================================
  Hits              ?     6902           
  Misses            ?     2976           
  Partials          ?      692

@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Sep 20, 2018 •
edited by amshinde
Loading

lgtm

Approved with PullApprove

@grahamwhaley grahamwhaley mentioned this pull request Sep 20, 2018
Closed
@grahamwhaley
Copy link
Copy Markdown
Contributor

grahamwhaley commented Sep 20, 2018

Travis in snooze mode - I don't see a build over at https://travis-ci.org/kata-containers/runtime/builds I'll spend a few minutes to see if I can see a reason why maybe.

@bergwolf
Copy link
Copy Markdown
Member Author

bergwolf commented Sep 20, 2018

It seems that travis decides I have sent to many build requests to them... I have contacted their support. Until they solve it, travis-ci will continue ignoring my PRs. sigh :(

The account bergwolf has been flagged for potential abuse. Please contact support@travis-ci.com.

@grahamwhaley
Copy link
Copy Markdown
Contributor

grahamwhaley commented Sep 20, 2018

Wow @bergwolf - that is the strangest 'sign of success' yet - err, congratulations on the many PRs ;-)

@gnawux
Copy link
Copy Markdown
Member

gnawux commented Sep 20, 2018

congrats @bergwolf; lol

@jcvenegas
Copy link
Copy Markdown
Member

jcvenegas commented Sep 20, 2018

I think it is ok to merge this PR by now. @sboeuf @amshinde

@amshinde
Copy link
Copy Markdown
Member

amshinde commented Sep 20, 2018

Yup. Lets merge :)

@amshinde amshinde merged commit 35d3c0b into kata-containers:master Sep 20, 2018
@bergwolf bergwolf mentioned this pull request Jan 7, 2019
Closed
@bergwolf bergwolf deleted the cleanup-template branch March 27, 2019 07:52
@teawater teawater mentioned this pull request Mar 29, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@grahamwhaley grahamwhaley grahamwhaley approved these changes

@amshinde amshinde amshinde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bergwolf @grahamwhaley @katacontainersbot @jodh-intel @gnawux @jcvenegas @amshinde