ci: increase timeout in unit tests#226
Conversation
|
lgtm |
|
lgtm. @devimc any reason for the |
grahamwhaley
left a comment
There was a problem hiding this comment.
Can you add some details over on #225 why we need to bump it over 10s - that is quite some time - what is taking/waiting >10s to complete?
Without any details it almost feels like we would continue to bump the timeout until the tests all passed ;-)
Increase timeout in `go test` to avoid panics while running virtcontainers unit tests. Panic occurs randomly and can be reproduced easily on systems running low on resources. This patch sets the timeout in 30 seconds, after having run all unit tests N times with the new timeout, the issues could not be reproduced. fixes kata-containers#225 Signed-off-by: Julio Montes <julio.montes@intel.com>
3552312 to
97fe3a4
Compare
no idea, feel free to debug it PR and issue's comment updated |
|
so @devimc , happens on VMs with 'low resources' - do we think we are running our VMs at their limits then - and if so, maybe the correct solution is to bump the VM size etc? fixing an issue without being able to show what was fixed and why generally imho means 'no idea' == 'NACK' ... I'll leave the call to others... |
|
@grahamwhaley ok, closing PR to let "others" fix the issue |
|
I think this is still needed (at least temporarily) to unblock the CI, I see that some |
|
@devimc Can we re-open this PR since it happens again sometimes? I don't see what harm it can bring us by just increasing the timeout from 10s to 30s. |
|
@bergwolf I'll try to investigate this today, but basically we would like to understand what's happening before to forcibly bump the timeout. |
|
@sboeuf any update on this ? |
|
@devimc didn't have enough time yesterday. Looking at it right now. |
in order to make log-parser happy, mockcontainer must return always a valid process with a fake PID, since log-parser checks that PID value in the logs and it must be different to zero Depends-on: github.com/kata-containers/tests#226 Signed-off-by: Julio Montes <julio.montes@intel.com>
Split qemu script to build qemu experimental using same dockerfile. Fixes: kata-containers#3255 Depends-on: github.com/kata-containers/tests#226 Signed-off-by: Carlos Venegas <jos.c.venegas.munoz@intel.com>
Increase timeout in
go testto avoid panics while runningvirtcontainers unit tests.
Panic occurs randomly and can be reproduced easily on systems running
low on resources. This patch sets the timeout in 30 seconds, after
having run all unit tests N times with the new timeout, the issues
could not be reproduced.
fixes #225
Signed-off-by: Julio Montes julio.montes@intel.com