ci: spell check: fix inverted test#2240
Conversation
|
/test |
It explains the details of current supported annotations. Fixes: kata-containers#486 Fixes: kata-containers#294 Depends-on: kata-containers/tests#2240 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
It explains the details of current supported annotations. Fixes: kata-containers#486 Fixes: kata-containers#294 Depends-on: github.com/kata-containers/tests#2240 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
|
Seems like something got broken in ARM node: /cc @Pennyzct |
|
I guess maybe |
.ci/static-checks.sh
Outdated
| done | ||
|
|
||
| [ $docs_failed -ne 0 ] && die "spell check failed, See https://github.com/kata-containers/documentation/blob/master/Documentation-Requirements.md#spelling for more information." | ||
| [ $docs_failed -ne 0 ] && die "spell check failed, See https://github.com/kata-containers/documentation/blob/master/Documentation-Requirements.md#spelling for more information." || true |
There was a problem hiding this comment.
I think this could be:
[ $docs_failed -eq 0 ] || die "spell check failed..."
and will save us one operation, wdyt?
There was a problem hiding this comment.
good call. I think I have 'script blindness'..... heh, so, I had to rewrite the commit message as well.... pushed!
|
(slightly off topic for this PR... but) - @Pennyzct - btw, watch out for code like this TMP_DIR=$(mktemp -d --tmpdir=/tmp ${testname}.XXX)which will over-ride your |
|
This is a slightly more useful search though: https://github.com/search?q=org%3Akata-containers+tmpdir+mktemp&type=Code |
During the merge of kata-containers#2228 the final check in the spell check got inverted - fix with a nice test inversion. Fixes: kata-containers#2239 Signed-off-by: Graham Whaley <graham.whaley@intel.com>
c308619 to
e7d8afd
Compare
|
/test-ubuntu |
It explains the details of current supported annotations. Fixes: kata-containers#486 Fixes: kata-containers#294 Depends-on: github.com/kata-containers/tests#2240 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
During the merge of #2228 the final check in the spell check got
inverted - fix with a
|| true.Fixes: #2239
Signed-off-by: Graham Whaley graham.whaley@intel.com