This repository was archived by the owner on Jun 28, 2024. It is now read-only.
CI: run virtcontainers unit tests only as root#219
Merged
sboeuf merged 1 commit intokata-containers:masterfrom Apr 6, 2018
Merged
CI: run virtcontainers unit tests only as root#219sboeuf merged 1 commit intokata-containers:masterfrom
sboeuf merged 1 commit intokata-containers:masterfrom
Conversation
grahamwhaley
approved these changes
Apr 6, 2018
Contributor
grahamwhaley
left a comment
There was a problem hiding this comment.
If we can maybe do a touch of investigation to pinpoint why the tests need to be run as root, and if we think there is a way we could improve that in the future then open an issue to cover that shortcoming - then...
lgtm
| printf "INFO: Running 'go test' as %s user on package '%s' with flags '%s'\n" \ | ||
| "$user" "$pkg" "$go_test_flags" | ||
|
|
||
| # Run virtcontainers tests only if user is root. |
Contributor
There was a problem hiding this comment.
Which is a little sad, but iirc it is because the vc tests need to install the cni plugins etc., which has to be done as root?
I wonder if the better fix is to ensure we sudo all the bits in the vc test setup so we can still run the tests?
f75a9ab to
4740095
Compare
d678f8c to
39394d6
Compare
Virtcontainers unit tests only work if they are executed using the root user. Fixes kata-containers#218. Depends-on: github.com/kata-containers/runtime#193 Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
|
LGTM |
jcvenegas
pushed a commit
to jcvenegas/kata-test
that referenced
this pull request
Apr 13, 2018
CI: run virtcontainers unit tests only as root
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtcontainers unit tests only work if they are executed
using the root user.
Fixes #218.
Depends-on: github.com/kata-containers/runtime#193
Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com