Add container restart case#2140
Conversation
e2ec530 to
fdf5fd3
Compare
Remove `TestClearContainersCreate` and correct `TestContainerListStatsWithSandboxIdFilterd` which cause the test suit to complain with "warning: no tests to run". Fixes: kata-containers#2138 Signed-off-by: Li Yuxuan <liyuxuan04@baidu.com>
fdf5fd3 to
f10f357
Compare
|
/test |
f10f357 to
2e7c1d9
Compare
|
It seems that not all the jobs run cri integration-tests with containerd configured. I've added a detection @chavafg |
|
/test |
2e7c1d9 to
528beb0
Compare
cdb6a00 to
6c9ebc3
Compare
|
/test |
|
CI seems happy now. I think the ARM job is not fail on this commit 😃 |
|
@chavafg OK:) |
|
Hi @chavafg, I've submitted to containerd/cri#1357. But as Liu said the case may be moved to cri-tools as well. Shall we merge this PR at first as kata-containers/runtime#2008 is waiting to be tested, and then switch to cri-tools or cri integration based one in future re-vendor? 😉 |
|
thanks @darfux, yeah, I think we can merge this, but need another ack. |
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
| // Copyright (c) 2018 Intel Corporation |
There was a problem hiding this comment.
nit: you could add yourself/org to the copyright header maybe if you wanted.
And trim the apache license header down to just the SPDX style one, to match the rest of the kata code.
There was a problem hiding this comment.
Thanks ! Updated to be consistent with the cri patch :)
Add a cri-containerd integration case that restart same container inside a pod. Fixes: kata-containers#2139 Signed-off-by: Li Yuxuan <liyuxuan04@baidu.com>
6c9ebc3 to
620681f
Compare
|
/test |
|
Restarted ARM CI which appeared to have failed due to a network timeout. |
This PR mainly adds a
crictlcri integration test patch based container restart case as well as fix two cases that doesn't exist in the cri integration test.I think it's better to add such case to https://github.com/containerd/cri/tree/master/integration and I'll try to raise a PR there about this later. If that case is merged then we can use it in future after vendor update :)
Fixes: #2138, #2139
Signed-off-by: Li Yuxuan liyuxuan04@baidu.com