Hi @darfux. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

appveyor test issue will be fixed by: #1358

Thanks :) @mikebrow

@darfux I'm fine with adding this test. :)

But I think this is a test that makes sense to move to cri-tools, so that it can cover both containerd and cri-o. :)

@darfux Do you want to do that?

/lgtm

@Random-Liu I can try it XD. Should I add such case to https://github.com/kubernetes-sigs/cri-tools/blob/master/pkg/validate/container.go? And will this case be removed from here finally? As the PR of kata is dependent on it now.

@darfux trying to confirm for the authors list, this is your name and email Li Yuxuan <liyuxuan04@baidu.com> ?

@darfux trying to confirm for the authors list, this is your name and email Li Yuxuan <liyuxuan04@baidu.com> ?

@dmcgowan Yes😉