This repository was archived by the owner on Jun 28, 2024. It is now read-only.
static-checks: only check files in Git index#1868
Merged
chavafg merged 1 commit intokata-containers:masterfrom Jul 29, 2019
Merged
static-checks: only check files in Git index#1868chavafg merged 1 commit intokata-containers:masterfrom
chavafg merged 1 commit intokata-containers:masterfrom
Conversation
Only run static checks on the files in the Git index, to avoid any side effects of checks failing because of untracked files, such as build artifacts. Fixes: kata-containers#1867 Signed-off-by: Marco Vedovati <mvedovati@suse.com>
|
/test |
Contributor
Author
|
@grahamwhaley can we ignore metrics and cri-containerd failures given I just changed static-checks? |
chavafg
approved these changes
Jul 29, 2019
Contributor
|
I think we can merge this one also as it is only related to static checks |
4 tasks
Contributor
|
yeah, my suspicion is that maybe the merge of the kernel fragments (we did merge that, right @devimc ?), has changed the metrics, but the baseline measures have not been updated in a PR yet. |
jodh-intel
pushed a commit
to jodh-intel/tests-1
that referenced
this pull request
Aug 2, 2019
We recently switched from using `find(1)` to `git-ls-files(1)` to determine which files run static checks for [1]. Unfortunately, the formats of these commands are slightly different so update the code to ignore vendor files as previously, vendor files were being checked. [1] - kata-containers#1868 Fixes: kata-containers#1892. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only run static checks on the files in the Git index, to avoid any side
effects of checks failing because of untracked files, such as build
artifacts.
Fixes: #1867
Signed-off-by: Marco Vedovati mvedovati@suse.com