stability: fix fc name in hypervisor kill tests#1847
stability: fix fc name in hypervisor kill tests#1847GabyCT merged 1 commit intokata-containers:masterfrom
Conversation
Because the tests repo doesn't test fc, I have to use the runtime repo ci to validate a tests PR for fc CI, for now. Fixes: #999999 Depends-on: github.com/kata-containers/tests#1847 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
grahamwhaley
left a comment
There was a problem hiding this comment.
lgtm
but I thought we'd already fixed this? @GabyCT @mcastelino
| # Set the runtime if not set already | ||
| RUNTIME="${RUNTIME:-kata-runtime}" | ||
|
|
||
| HYPERVISOR_NAME=$(basename ${HYPERVISOR_PATH}) |
There was a problem hiding this comment.
nit: you can use shell magic here like ${HYPERVISOR_PATH%/*} or similar ;-)
There was a problem hiding this comment.
Wow, that is real magic ;)
|
Because tests repo doesn't validate fc in CI, I'm trying to test it in a runtime PR, see kata-containers/runtime#1905 |
|
@grahamwhaley It's the same issue but in a different test case -- the one I just added to killing hypervisor process. |
97026ac to
6765b0d
Compare
|
/test |
|
@GabyCT any idea of why fc job is not being triggered here? |
|
/test |
|
@chavafg I can see that now is being triggered |
|
thanks @GabyCT, I see it now 😄 |
|
/test-fc |
|
@bergwolf , if you want to launch the |
bd4ed4d to
46be404
Compare
|
/test |
e84573c to
d0d6e81
Compare
|
/test |
|
/test-fc |
Instead of taking the full path name of the hypervisors, we need to change to use only the name of the process because with jailer we have different path shown there. Fixes: kata-containers#1848 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
|
/test |
Instead of taking the full path name of the hypervisors, we need to
change to use only the name of the process because with jailer we have
different path shown there.
Fixes: #1846