This repository was archived by the owner on Jun 28, 2024. It is now read-only.
ci: fix install_runtime.sh and add support for using acrn config file#1793
Merged
amshinde merged 2 commits intokata-containers:masterfrom Jul 10, 2019
Merged
Conversation
`kata-runtime kata-check` will fail if the hypervisor in the kata runtime config file is not found. Fixes: kata-containers#1792. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
Once kata-containers/runtime#1779 is merged, we will be able to run CI using acrn hypervisor. Add support for running kata with acrn using its dedicated configuration file. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
GabyCT
approved these changes
Jul 10, 2019
Contributor
Author
|
/tes |
Contributor
|
/test |
Contributor
Author
|
ouch, thanks @grahamwhaley |
jodh-intel
approved these changes
Jul 10, 2019
jodh-intel
left a comment
There was a problem hiding this comment.
lgtm
For the future: I do wonder if it would be better to handle this with a case now though, or change the logic to add an else and error if we find something unexpected (KATA_HYPERVISOR="funky_new_hypervisor")?
amshinde
approved these changes
Jul 10, 2019
Member
|
Rerunning failing fedora and vsocks CI. |
vijaydhanraj
added a commit
to vijaydhanraj/runtime
that referenced
this pull request
Jul 10, 2019
ACRN hypervisor is a type-1 hypervisor and this patch adds support to check and validate if the system is capable of running kata containers with ACRN hypervisor. Depends-on: github.com/kata-containers/tests#1793 v3->v4: Implemented a generic way to identify hypervisor and test VM creation. v2->v3: 1. Removed cgo structs and defined go structs. 2. Suppressed lint warnings due to unused createVM struct. v1->v2: 1. Created an issue kata-containers#1784 to address TODO item. 2. Fixed formatting of the log message. 3. Currently ACRN is only supported on amd64. So moved ACRN specific code to kata-check_amd64.go. Fixes: kata-containers#1778 Signed-off-by: Vijay Dhanraj <vijay.dhanraj@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once kata-containers/runtime#1779 is merged, we will be able
to run CI using
acrnhypervisor. Add support for running katawith acrn using its dedicated configuration file.
In addition,
kata-runtime kata-checkwill fail if the hypervisorin the kata runtime config file is not found, so run kata-check
after correct config file is in place.