Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

ci: run runtime's unit tests in centos#1414

Merged
chavafg merged 1 commit intokata-containers:masterfrom
devimc:topic/unskipCentosUnitests
Apr 25, 2019
Merged

ci: run runtime's unit tests in centos#1414
chavafg merged 1 commit intokata-containers:masterfrom
devimc:topic/unskipCentosUnitests

Conversation

@devimc
Copy link
Copy Markdown

@devimc devimc commented Apr 3, 2019

run runtime's unit tests in centos

fixes #1413

Signed-off-by: Julio Montes julio.montes@intel.com

@devimc
Copy link
Copy Markdown
Author

devimc commented Apr 3, 2019

/test-centos

@devimc
Copy link
Copy Markdown
Author

devimc commented Apr 3, 2019

/test

devimc pushed a commit to devimc/kata-runtime that referenced this pull request Apr 3, 2019
Old kernels, like 3.x, does not support cgroup namespace. Skip the test that
checks this namespace if its path in /proc doesn't exist.

Depends-on: github.com/kata-containers/tests#1414

fixes kata-containers#228

Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc pushed a commit to devimc/kata-runtime that referenced this pull request Apr 4, 2019
Depending of the linux versions some namespaces are supported or not.
To avoid failures running containers and unit tests in old linux kernels,
only the supported namespaces should be used.

Depends-on: github.com/kata-containers/tests#1414

fixes kata-containers#228

Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc pushed a commit to devimc/kata-runtime that referenced this pull request Apr 4, 2019
Depending of the linux versions some namespaces are supported or not.
To avoid failures running containers and unit tests in old linux kernels,
only the supported namespaces should be used.

Depends-on: github.com/kata-containers/tests#1414

fixes kata-containers#228

Signed-off-by: Julio Montes <julio.montes@intel.com>
@GabyCT
Copy link
Copy Markdown
Contributor

GabyCT commented Apr 4, 2019

We need the PR runtime to be first merged

devimc pushed a commit to devimc/kata-runtime that referenced this pull request Apr 8, 2019
Depending of the linux versions some namespaces are supported or not.
To avoid failures running containers and unit tests in old linux kernels,
only the supported namespaces should be used.

Depends-on: github.com/kata-containers/tests#1414

fixes kata-containers#228

Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc pushed a commit to devimc/kata-runtime that referenced this pull request Apr 9, 2019
Depending of the linux versions some namespaces are supported or not.
To avoid failures running containers and unit tests in old linux kernels,
only the supported namespaces should be used.

Depends-on: github.com/kata-containers/tests#1414

fixes kata-containers#228

Signed-off-by: Julio Montes <julio.montes@intel.com>
@devimc devimc force-pushed the topic/unskipCentosUnitests branch from 3401ea6 to bdc9804 Compare April 23, 2019 20:17
@devimc
Copy link
Copy Markdown
Author

devimc commented Apr 23, 2019

/test

@jodh-intel
Copy link
Copy Markdown

@devimc:

if kata.Distro("rhel") {
    Skip("Issue: ...")
}

That way, we'd still be testing most of the code on RHEL.

/cc @amshinde.

@jodh-intel
Copy link
Copy Markdown

@devimc - we could land this "as-is" - I've got some code that might do what we want later to just run this test: #1496.

run runtime's unit tests in centos

fixes kata-containers#1413

Signed-off-by: Julio Montes <julio.montes@intel.com>
@devimc devimc force-pushed the topic/unskipCentosUnitests branch from bdc9804 to 7db8877 Compare April 24, 2019 17:30
@devimc
Copy link
Copy Markdown
Author

devimc commented Apr 24, 2019

/test

@jodh-intel
Copy link
Copy Markdown

Related: kata-containers/runtime#1587.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: run runtime's unit tests in centos

4 participants