Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

ci: don't check license of C files distributed under the GPL license#1280

Merged
chavafg merged 1 commit intokata-containers:masterfrom
devimc:topic/skipCGPL
Mar 11, 2019
Merged

ci: don't check license of C files distributed under the GPL license#1280
chavafg merged 1 commit intokata-containers:masterfrom
devimc:topic/skipCGPL

Conversation

@devimc
Copy link
Copy Markdown

@devimc devimc commented Mar 11, 2019

Sometimes we need to include C files distributed under the GPL license, to
avoid issues with the tool that checks file headers, files with the suffix
.gpl.c are skipped.

fixes #1279

Signed-off-by: Julio Montes julio.montes@intel.com

Sometimes we need to include C files distributed under the GPL license, to
avoid issues with the tool that checks file headers, files with the suffix
`.gpl.c` are skipped.

fixes kata-containers#1279

Signed-off-by: Julio Montes <julio.montes@intel.com>
Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if others agree with that nomenclature, then lgtm

Copy link
Copy Markdown

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cute!

lgtm

Copy link
Copy Markdown
Contributor

@chavafg chavafg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
I don't think we need to run the whole CI for this, so merging...

@chavafg chavafg merged commit 343ee8f into kata-containers:master Mar 11, 2019
devimc pushed a commit to devimc/kata-osbuilder that referenced this pull request Mar 11, 2019
The new NVDIMM driver implementation (kernel >= 4.16) needs to know the device
namespace information to map pages, this metadata is read from the nvdimm
namespace at 4k offset.

Depends-on: github.com/kata-containers/tests#1280

fixes kata-containers#235

Signed-off-by: Julio Montes <julio.montes@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: don't check header of GPL file

4 participants