Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

virtcontainers: agent: fix CPU hot plug race condition#91

Merged
devimc merged 2 commits intokata-containers:masterfrom
devimc:cpu/fixRaceCondition
Apr 13, 2018
Merged

virtcontainers: agent: fix CPU hot plug race condition#91
devimc merged 2 commits intokata-containers:masterfrom
devimc:cpu/fixRaceCondition

Conversation

@devimc
Copy link
Copy Markdown

@devimc devimc commented Mar 21, 2018

Communicate to the agent the number of vCPUs that were hot added,
allowing to the agent wait for the creation of all vCPUs.

fixes #90

Signed-off-by: Julio Montes julio.montes@intel.com

@devimc
Copy link
Copy Markdown
Author

devimc commented Mar 21, 2018

Depends-on: kata-containers/agent#182
kata agent needs to be re-vendored

Copy link
Copy Markdown

@sboeuf sboeuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kata-containers/agent protocol needs to be re-vendored but this PR looks good.

@devimc devimc force-pushed the cpu/fixRaceCondition branch 2 times, most recently from 51a7beb to 95e1584 Compare March 23, 2018 15:46
@devimc devimc force-pushed the cpu/fixRaceCondition branch from 95e1584 to 3e0f282 Compare April 10, 2018 13:47
@devimc
Copy link
Copy Markdown
Author

devimc commented Apr 10, 2018

kata-containers/agent#182 got merged , @kata-containers/runtime PTAL

@devimc devimc force-pushed the cpu/fixRaceCondition branch from 2cd3afa to 3e0f282 Compare April 10, 2018 14:30
@devimc
Copy link
Copy Markdown
Author

devimc commented Apr 10, 2018

Depends-on: #173

@devimc
Copy link
Copy Markdown
Author

devimc commented Apr 10, 2018

#173 got merged, PTAL

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2018

Codecov Report

Merging #91 into master will decrease coverage by 0.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage    65.1%   65.09%   -0.02%     
==========================================
  Files          73       73              
  Lines        7695     7697       +2     
==========================================
  Hits         5010     5010              
- Misses       2142     2144       +2     
  Partials      543      543
Impacted Files Coverage Δ
virtcontainers/agent.go 92.15% <ø> (ø) ⬆️
virtcontainers/hyperstart_agent.go 57.89% <0%> (ø) ⬆️
virtcontainers/kata_agent.go 28.77% <0%> (-0.12%) ⬇️
virtcontainers/noop_agent.go 91.66% <100%> (ø) ⬆️
virtcontainers/container.go 46.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db9b28...da6d284. Read the comment docs.

@devimc
Copy link
Copy Markdown
Author

devimc commented Apr 12, 2018

lgtm 🎊

Copy link
Copy Markdown
Member

@amshinde amshinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Julio Montes added 2 commits April 13, 2018 07:05
Communicate to the agent the number of vCPUs that were hot added,
allowing to the agent wait for the creation of all vCPUs.

fixes kata-containers#90

Signed-off-by: Julio Montes <julio.montes@intel.com>
This new version of kata-containers agent includes
the fix for CPU hotplug race condition

Shortlog:
131554d network: specify netlink protocol
49f01ed protocols/grpc: fix CPU hotplug race condition
ee7850d mockreaper: implement mock reaper
9f60034 reaper: implement reaper interface

Signed-off-by: Julio Montes <julio.montes@intel.com>
@devimc devimc force-pushed the cpu/fixRaceCondition branch from f17f28f to da6d284 Compare April 13, 2018 12:06
@devimc
Copy link
Copy Markdown
Author

devimc commented Apr 13, 2018

rebased

@devimc
Copy link
Copy Markdown
Author

devimc commented Apr 13, 2018

@devimc devimc merged commit 0f9defd into kata-containers:master Apr 13, 2018
@devimc devimc removed the review label Apr 13, 2018
@devimc devimc deleted the cpu/fixRaceCondition branch May 9, 2018 15:39
stefanha pushed a commit to stefanha/runtime that referenced this pull request Apr 12, 2019
Shortlog:
b3e7a9e Merge pull request kata-containers#91 from stefanha/virtio-fs-cache-size-mb
058cda0 qemu: use MiB instead of Gib for virtio-fs cache size

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
stefanha pushed a commit to stefanha/runtime that referenced this pull request Apr 17, 2019
Shortlog:
b3e7a9e Merge pull request kata-containers#91 from stefanha/virtio-fs-cache-size-mb
058cda0 qemu: use MiB instead of Gib for virtio-fs cache size

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
stefanha pushed a commit to stefanha/runtime that referenced this pull request Apr 18, 2019
Shortlog:
b3e7a9e Merge pull request kata-containers#91 from stefanha/virtio-fs-cache-size-mb
058cda0 qemu: use MiB instead of Gib for virtio-fs cache size

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
stefanha pushed a commit to stefanha/runtime that referenced this pull request May 1, 2019
Shortlog:
b3e7a9e Merge pull request kata-containers#91 from stefanha/virtio-fs-cache-size-mb
058cda0 qemu: use MiB instead of Gib for virtio-fs cache size

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
zklei pushed a commit to zklei/runtime that referenced this pull request Jun 13, 2019
…ntral-check-script

CI: switch to central static check script
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CPU hot plug race condition

4 participants