This repository was archived by the owner on May 12, 2021. It is now read-only.
api: To watch the vm console in FetchSandbox api#442
Merged
devimc merged 1 commit intokata-containers:masterfrom Jul 4, 2018
Merged
api: To watch the vm console in FetchSandbox api#442devimc merged 1 commit intokata-containers:masterfrom
devimc merged 1 commit intokata-containers:masterfrom
Conversation
Contributor
|
PSS Measurement: Memory inside container: |
jodh-intel
approved these changes
Jun 25, 2018
virtcontainers/sandbox.go
Outdated
| return fmt.Errorf("sandbox %s missed agent pointer", s.ID()) | ||
| } | ||
|
|
||
| err := s.agent.startProxy(s) |
There was a problem hiding this comment.
Nit: You could simplify this to simply:
return s.agent.startProxy(s)
devimc
reviewed
Jun 25, 2018
virtcontainers/api.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| /* If the proxy is KataBuiltInProxyType type, it needs to restart the proxy to watch the |
devimc
reviewed
Jun 25, 2018
virtcontainers/sandbox.go
Outdated
|
|
||
| func (s *Sandbox) startProxy() error { | ||
|
|
||
| /* If the proxy is KataBuiltInProxyType type, it needs to restart the proxy |
Member
Author
There was a problem hiding this comment.
Hi, Devimc
I had fixed the issues, do you have any comments?
Thanks!
Fupan
When do sandbox release, the kataBuiltInProxy will be closed, and it will stop the watch of vm's console; Thus it needs to restart the proxy to monitor the vm console once to restore the sandbox. Fixes: kata-containers#441 Signed-off-by: fupan <lifupan@gmail.com>
f54df34 to
9155412
Compare
Contributor
|
PSS Measurement: Memory inside container: |
Member
|
/lgtm Jenkins failed on 'crio' though. Might be related to kata-containers/tests/issues/361 |
bergwolf
approved these changes
Jul 4, 2018
Member
|
@devimc do you want to take another look? |
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
=========================================
Coverage ? 64.07%
=========================================
Files ? 87
Lines ? 8874
Branches ? 0
=========================================
Hits ? 5686
Misses ? 2576
Partials ? 612
Continue to review full report at Codecov.
|
|
lgtm |
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
There are 2 phases in Memory Hotplug. 1) Physical Memory Hotplug phase. 2) Logical Memory Hotplug phase. The First phase is to communicate hardware/firmware and make/erase environment for hotplugged memory. If firmware supports notification of connection of new memory to OS, this phase is triggered automatically. ACPI can notify this event. This also what kata supports on amd64, memory hotplug via acpi-driven. But if not, there is another option, probe operation by hand. And since memory hotplug via acpi is missing on qemu-system-aarch64, we hope to support the other probe solution. This whole implementation of memory hotplug via probe interface is divided into two phases, the first is to check if guest kernel is capable of memory hot-add via probe interface, which is located at /sys/devices/system/memory/probe. Fixes: kata-containers#442 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
There are 2 phases in Memory Hotplug. 1) Physical Memory Hotplug phase. 2) Logical Memory Hotplug phase. The First phase is to communicate hardware/firmware and make/erase environment for hotplugged memory. If firmware supports notification of connection of new memory to OS, this phase is triggered automatically. ACPI can notify this event. This also what kata supports on amd64, memory hotplug via acpi-driven. But if not, there is another option, probe operation by hand. And since memory hotplug via acpi is missing on qemu-system-aarch64, we hope to support the other probe solution. This whole implementation of memory hotplug via probe interface is divided into two phases, the first is covered by former commit. The second is to notify guest kernel about hot-added momery event by echoing related addresses into /sys/devices/system/memory/probe. Fixes: kata-containers#442 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
since we add extra functionality in func GetGuestDetails for memory hotplug via probe interface, we need to refine its related unit test. Fixes: kata-containers#442 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When do sandbox release, the kataBuiltInProxy will
be closed, and it will stop the watch of vm's console;
Thus it needs to restart the proxy to monitor the vm
console once to restore the sandbox.
Fixes: #441
Signed-off-by: fupan lifupan@gmail.com