Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

virtcontainers: kata_agent: apply CPU constraints#205

Merged
egernst merged 1 commit intokata-containers:masterfrom
devimc:constraints/CPU
Apr 13, 2018
Merged

virtcontainers: kata_agent: apply CPU constraints#205
egernst merged 1 commit intokata-containers:masterfrom
devimc:constraints/CPU

Conversation

@devimc
Copy link
Copy Markdown

@devimc devimc commented Apr 12, 2018

The runtime already hot added the number of vCPUs needed by each container,
in order to have a better control over those resources, CPU constraints
must be applied.

fixes #203

Signed-off-by: Julio Montes julio.montes@intel.com

@devimc devimc added the review label Apr 12, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2018

Codecov Report

Merging #205 into master will increase coverage by 0.24%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage    65.1%   65.35%   +0.24%     
==========================================
  Files          73       73              
  Lines        7695     7700       +5     
==========================================
+ Hits         5010     5032      +22     
+ Misses       2142     2125      -17     
  Partials      543      543
Impacted Files Coverage Δ
virtcontainers/kata_agent.go 33.06% <0%> (+4.16%) ⬆️
virtcontainers/podlist.go
virtcontainers/pod.go
virtcontainers/pkg/vcmock/pod.go
virtcontainers/sandbox.go 66.34% <0%> (ø)
virtcontainers/sandboxlist.go 90% <0%> (ø)
virtcontainers/pkg/vcmock/sandbox.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca25177...a4c0827. Read the comment docs.

The runtime already hot added the number of vCPUs needed by each container,
in order to have a better control over those resources, CPU constraints
must be applied.

fixes kata-containers#203

Signed-off-by: Julio Montes <julio.montes@intel.com>
@devimc
Copy link
Copy Markdown
Author

devimc commented Apr 12, 2018

added unit test

@devimc
Copy link
Copy Markdown
Author

devimc commented Apr 13, 2018

@egernst egernst merged commit ad5669f into kata-containers:master Apr 13, 2018
@egernst egernst removed the review label Apr 13, 2018
@devimc devimc deleted the constraints/CPU branch May 9, 2018 15:38
zklei pushed a commit to zklei/runtime that referenced this pull request Jun 13, 2019
The rollback does not work as expected because the error has to be
checked from the defer itself.

Fixes kata-containers#205

Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

apply CPU constraints inside the VM

4 participants