Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

cli: delete out-of-date comment#180

Merged
jodh-intel merged 1 commit intokata-containers:masterfrom
caoruidong:delete-comment
Apr 4, 2018
Merged

cli: delete out-of-date comment#180
jodh-intel merged 1 commit intokata-containers:masterfrom
caoruidong:delete-comment

Conversation

@caoruidong
Copy link
Copy Markdown
Member

Function getContainerInfo dosen't expand container id from prefix now

Fixes #139

Signed-off-by: Ruidong Cao caoruidong@huawei.com

@bergwolf
Copy link
Copy Markdown
Member

bergwolf commented Apr 4, 2018

lgtm

Approved with PullApprove

@jodh-intel
Copy link
Copy Markdown

lgtm

@jodh-intel
Copy link
Copy Markdown

Hmm, pullapprove seems to be stuck - I am an approver and I've approved both via github and pullapprove.

Merging...

@jodh-intel jodh-intel merged commit bc83bf0 into kata-containers:master Apr 4, 2018
Function getContainerInfo dosen't expand container id from prefix now

Fixes kata-containers#139

Signed-off-by: Ruidong Cao <caoruidong@huawei.com>
bergwolf added a commit to bergwolf/kata-runtime that referenced this pull request Apr 7, 2018
To include the grpc yamux dialer.

Included kata agent git shortlog:
Archana Shinde (1):
      mount: Correct error message with mount failure.

Eric Ernst (2):
      Merge pull request kata-containers#196 from sboeuf/fix_rollback
      Merge pull request kata-containers#201 from bergwolf/yamux_client

Graham whaley (1):
      ci: lib: allow override of tests_repo

James O. D. Hunt (16):
      mount: Log params and validate
      device: Add validation and debug
      tests: Move helper function
      tests: Use root skip function
      tests: Skip more tests if non-root
      CI: Require pullapprove ack for protocol changes
      agent: Add announce function
      announce: Add standard fields when running as PID 1
      announce: Add device and storage handlers
      announce: Add total memory
      Merge pull request kata-containers#180 from jodh-intel/add-announce-log-call
      github: Add issue template
      Merge pull request kata-containers#189 from grahamwhaley/20180322_tests_repo
      Merge pull request kata-containers#187 from jodh-intel/github-issue-template
      Merge pull request kata-containers#192 from sboeuf/fix_device
      Merge pull request kata-containers#197 from amshinde/correct-err-msg

Lai Jiangshan (1):
      Merge pull request kata-containers#176 from jodh-intel/pullapprove-for-grpc-changes

Peng Tao (3):
      Merge pull request kata-containers#171 from jodh-intel/validate-mount-params
      Merge pull request kata-containers#206 from sboeuf/fix_rollback
      protocol: client: enable builtin yamux client support

Sebastien Boeuf (7):
      Merge pull request kata-containers#178 from jodh-intel/skip-more-tests-if-not-root
      Merge pull request kata-containers#173 from jodh-intel/add-device-debug
      device: VmPath can be empty if an Id is provided
      agent: Rollback properly when container creation fails
      vendor: Update libcontainer vendoring
      Merge pull request kata-containers#203 from sboeuf/revendor_libcontainer
      agent: Fix container creation rollback

Signed-off-by: Peng Tao <bergwolf@gmail.com>
@caoruidong caoruidong deleted the delete-comment branch April 8, 2018 12:24
zklei pushed a commit to zklei/runtime that referenced this pull request Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mismatch between code and comments

3 participants