This repository was archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: Use shim to print the agent logs if there is no proxy#1597
Merged
jodh-intel merged 1 commit intokata-containers:masterfrom May 1, 2019
Merged
Conversation
The proxy is in charge to print the agent logs, but when `use_vsocks` is true the runtime doesn't start the proxy, because it's not needed, hence the agent logs are ignored. To mitigate this limitation and to make the debugging processes easier, the fist shim started (the one who monitors the sandbox) will read the console.sock and print the agent logs. Depends-on: github.com/kata-containers/shim#172 fixes kata-containers#1596 Signed-off-by: Julio Montes <julio.montes@intel.com>
Author
|
/test |
Author
|
@marcov @jodh-intel @sboeuf please take a look |
devimc
pushed a commit
to devimc/kata-tests
that referenced
this pull request
Apr 29, 2019
Agent logs should be in the shim journal when `use_vsock` and shim debug are enabled. Depends-on: github.com/kata-containers/runtime#1597 fixes kata-containers#1509 Signed-off-by: Julio Montes <julio.montes@intel.com>
Contributor
|
lgtm |
Author
Contributor
grahamwhaley
left a comment
There was a problem hiding this comment.
l g t m
but I've cc'd a couple of other reviewers who will have more insight then me.
sboeuf
approved these changes
Apr 30, 2019
jodh-intel
approved these changes
May 1, 2019
jodh-intel
left a comment
There was a problem hiding this comment.
Nice!
lgtm
Btw, thanks to the fact that the log-parser tool is as generic as possible, with use_vsock=true, it will still dtrt wrt agent logs embedded inside the shim logs rather than being embedded in the proxy logs 😄
|
The single CI failure is #1604, so we can ignore that as it's unrelated to this PR. Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proxy is in charge to print the agent logs, but when
use_vsocksis truethe runtime doesn't start the proxy, because it's not needed, hence the agent
logs are ignored. To mitigate this limitation and to make the debugging
process easier, the fist shim started (the one who monitors the sandbox)
will read the console.sock and print the agent logs.
Depends-on: github.com/kata-containers/shim#172
fixes #1596
Signed-off-by: Julio Montes julio.montes@intel.com