This repository was archived by the owner on May 12, 2021. It is now read-only.
config: fix panic in type assertion#1441
Merged
lifupan merged 1 commit intokata-containers:masterfrom Apr 8, 2019
Ace-Tang:fix-panic
Merged
config: fix panic in type assertion#1441lifupan merged 1 commit intokata-containers:masterfrom Ace-Tang:fix-panic
lifupan merged 1 commit intokata-containers:masterfrom
Ace-Tang:fix-panic
Conversation
when use shim v2 interface to run container, no need to use kata-proxy and kata-shim, remove kata-proxy and kata-shim in config file will cause panic since type assertion. add check to avoid panic Fixes: #1440 Signed-off-by: Ace-Tang <aceapril@126.com>
Member
|
/test |
devimc
approved these changes
Mar 28, 2019
sboeuf
approved these changes
Mar 28, 2019
egernst
approved these changes
Mar 29, 2019
Member
|
/retest |
Member
|
/test |
jshachm
approved these changes
Apr 3, 2019
ganeshmaharaj
pushed a commit
to ganeshmaharaj/kata-runtime
that referenced
this pull request
Apr 16, 2019
config: fix panic in type assertion (cherry picked from commit 303f126)
This was referenced Apr 16, 2019
ganeshmaharaj
pushed a commit
to ganeshmaharaj/kata-runtime
that referenced
this pull request
Apr 16, 2019
config: fix panic in type assertion (cherry picked from commit 303f126) Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj
pushed a commit
to ganeshmaharaj/kata-runtime
that referenced
this pull request
Apr 16, 2019
config: fix panic in type assertion (cherry picked from commit 303f126) Fixes: kata-containers#1440 Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj
pushed a commit
to ganeshmaharaj/kata-runtime
that referenced
this pull request
Apr 16, 2019
config: fix panic in type assertion (cherry picked from commit 303f126) Fixes: kata-containers#1440 Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when use shim v2 interface to run container, no need to use kata-proxy
and kata-shim, remove kata-proxy and kata-shim in config file will cause
panic since type assertion. add check to avoid panic
Fixes: #1440
Signed-off-by: Ace-Tang aceapril@126.com