Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

CI: add a CODEOWNERS file#135

Merged
jodh-intel merged 1 commit intokata-containers:masterfrom
grahamwhaley:20190110_codeowners
Jan 14, 2019
Merged

CI: add a CODEOWNERS file#135
jodh-intel merged 1 commit intokata-containers:masterfrom
grahamwhaley:20190110_codeowners

Conversation

@grahamwhaley
Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley commented Jan 10, 2019

Add a CODEOWNERS file, explicitly listing the
@kata-containers/documentation group as the owners
of all *.md files.

This is used as part of the github 'review and ack' automated
process.

Fixes: #134

Signed-off-by: Graham Whaley graham.whaley@intel.com

CI: add a CODEOWNERS file
3be7e68 
Add a CODEOWNERS file, explicitly listing the
@kata-containers/documentation group as the owners
of all *.md files.

This is used as part of the github 'review and ack' automated
process.

Fixes: kata-containers#134

Signed-off-by: Graham Whaley <graham.whaley@intel.com>
@grahamwhaley
Copy link
Copy Markdown
Contributor Author

grahamwhaley commented Jan 10, 2019

@ttx @fungi Let's see if we can use github groups/teams in the github CODEOWNERS file.
I chose to place this in the toplevel dir rather than the optional .github subdir, as it is much more visible to everybody that way.

I have also enabled github 'two ack' checking on this repo - and I see github is now putting up a 'merged blocked automatically' message on this PR, as expected.

@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Jan 10, 2019 •
edited by amshinde
Loading

lgtm

Approved with PullApprove

@grahamwhaley
Copy link
Copy Markdown
Contributor Author

grahamwhaley commented Jan 10, 2019

@jodh-intel - did you actually 'ack' this through the github review dialog - as I don't think the l g t m has registered (github will only note the 'approval' tick box in the dialog I reckon).

@jodh-intel jodh-intel self-requested a review January 10, 2019 16:47
jodh-intel
jodh-intel approved these changes Jan 10, 2019
View reviewed changes
Copy link
Copy Markdown

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm again!

@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Jan 10, 2019

...grumble...

@grahamwhaley
Copy link
Copy Markdown
Contributor Author

grahamwhaley commented Jan 10, 2019

thx - now we see if another ack clears the github approval check.
travis failing on the osx/brew issue by the look of it.

@opendev-zuul
Copy link
Copy Markdown

opendev-zuul bot commented Jan 10, 2019

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@grahamwhaley
Copy link
Copy Markdown
Contributor Author

grahamwhaley commented Jan 10, 2019

Just for ref, we got a zuul build fail:

2019-01-10 17:04:52.206145 | ubuntu-xenial | ubuntu-xenial-vexxhost-vexxhost-sjc1-0001618714   NotReady   master   6s    v1.12.2
2019-01-10 17:04:52.338263 | ubuntu-xenial | No resources found.
2019-01-10 17:04:52.946735 | ubuntu-xenial | clusterrole.rbac.authorization.k8s.io/flannel created
2019-01-10 17:04:52.954742 | ubuntu-xenial | clusterrolebinding.rbac.authorization.k8s.io/flannel created
2019-01-10 17:04:52.961960 | ubuntu-xenial | serviceaccount/flannel created
2019-01-10 17:04:52.983236 | ubuntu-xenial | configmap/kube-flannel-cfg created
2019-01-10 17:04:52.998087 | ubuntu-xenial | daemonset.extensions/kube-flannel-ds-amd64 created
2019-01-10 17:04:53.007249 | ubuntu-xenial | daemonset.extensions/kube-flannel-ds-arm64 created
2019-01-10 17:04:53.015229 | ubuntu-xenial | daemonset.extensions/kube-flannel-ds-arm created
2019-01-10 17:04:53.036511 | ubuntu-xenial | daemonset.extensions/kube-flannel-ds-ppc64le created
2019-01-10 17:04:53.045999 | ubuntu-xenial | daemonset.extensions/kube-flannel-ds-s390x created
2019-01-10 17:04:53.160060 | ubuntu-xenial | No resources found.
2019-01-10 17:04:58.277981 | ubuntu-xenial | No resources found.
2019-01-10 17:05:03.388008 | ubuntu-xenial | No resources found.
2019-01-10 17:06:55.835689 | ubuntu-xenial | Makefile:69: recipe for target 'kubernetes' failed
2019-01-10 17:06:55.835861 | ubuntu-xenial | make: *** [kubernetes] Error 1
2019-01-10 17:06:56.191004 | ubuntu-xenial | ERROR
2019-01-10 17:06:56.191424 | ubuntu-xenial | {
2019-01-10 17:06:56.191539 | ubuntu-xenial |   "delta": "0:47:40.594219",
2019-01-10 17:06:56.191644 | ubuntu-xenial |   "end": "2019-01-10 17:06:55.839611",
2019-01-10 17:06:56.191745 | ubuntu-xenial |   "msg": "non-zero return code",
2019-01-10 17:06:56.191844 | ubuntu-xenial |   "rc": 2,
2019-01-10 17:06:56.191943 | ubuntu-xenial |   "start": "2019-01-10 16:19:15.245392"
2019-01-10 17:06:56.192041 | ubuntu-xenial | }

@grahamwhaley grahamwhaley requested a review from chavafg January 10, 2019 22:08
chavafg
chavafg approved these changes Jan 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@chavafg chavafg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grahamwhaley
Copy link
Copy Markdown
Contributor Author

grahamwhaley commented Jan 12, 2019

github ack approval is happy with the 2 acks we have here. Pullapprove would still like to see another from a member of @kata-containers/proxy
The travis fail is a known OSX fail. The Zuul fail I don't think we were expecting to pass. Now let's try the rest of the CIs...

/test

This was referenced Jan 12, 2019
Closed
Closed
@caoruidong
Copy link
Copy Markdown
Member

caoruidong commented Jan 13, 2019 •
edited by amshinde
Loading

lgtm

Approved with PullApprove

@grahamwhaley
Copy link
Copy Markdown
Contributor Author

grahamwhaley commented Jan 13, 2019

Hmm, I think this is nothing to do with this PR, but it is a little concerning that some of our CIs seem to be failing - for instance, from the centos-7.4 we have:

./hack/test-utils.sh: line 63: 60467 Terminated              keepalive "sudo PATH=${PATH} ${ROOT}/_output/containerd ${CONTAINERD_FLAGS}" ${RESTART_WAIT_PERIOD} &>${report_dir}/containerd.log
make[1]: Leaving directory `/tmp/jenkins/workspace/kata-containers-proxy-centos-7-4-PR/go/src/github.com/containerd/cri'
INFO: containerd(cri): Running test-integration
make[1]: Entering directory `/tmp/jenkins/workspace/kata-containers-proxy-centos-7-4-PR/go/src/github.com/containerd/cri'
1 attempt "sudo /tmp/jenkins/workspace/kata-containers-proxy-centos-7-4-PR/go/bin/crictl --runtime-endpoint=unix:///run/containerd/containerd.sock info"! Trying again in 1 seconds...
2 attempt "sudo /tmp/jenkins/workspace/kata-containers-proxy-centos-7-4-PR/go/bin/crictl --runtime-endpoint=unix:///run/containerd/containerd.sock info"! Trying again in 2 seconds...
3 attempt "sudo /tmp/jenkins/workspace/kata-containers-proxy-centos-7-4-PR/go/bin/crictl --runtime-endpoint=unix:///run/containerd/containerd.sock info"! Trying again in 3 seconds...
4 attempt "sudo /tmp/jenkins/workspace/kata-containers-proxy-centos-7-4-PR/go/bin/crictl --runtime-endpoint=unix:///run/containerd/containerd.sock info"! Trying again in 4 seconds...
E0113 10:31:36.762181   61471 remote_runtime.go:266] ListContainers with filter &ContainerFilter{Id:,State:nil,PodSandboxId:,LabelSelector:map[string]string{},} from runtime service failed: rpc error: code = Unimplemented desc = unknown service runtime.v1alpha2.RuntimeService
time="2019-01-13T10:31:36Z" level=fatal msg="Failed to connect daemons" error="failed to list containers: rpc error: code = Unimplemented desc = unknown service runtime.v1alpha2.RuntimeService" 
./hack/test-utils.sh: line 63: 61381 Terminated              keepalive "sudo PATH=${PATH} ${ROOT}/_output/containerd ${CONTAINERD_FLAGS}" ${RESTART_WAIT_PERIOD} &>${report_dir}/containerd.log
make[1]: *** [test-integration] Error 1
make[1]: Leaving directory `/tmp/jenkins/workspace/kata-containers-proxy-centos-7-4-PR/go/src/github.com/containerd/cri'
make: *** [shimv2] Error 2

@chavafg - how are the CIs right now - do we have known instabilities?

@chavafg
Copy link
Copy Markdown
Contributor

chavafg commented Jan 14, 2019

yes, shimv2 test on CentOS is flaky. I opened kata-containers/tests#1047 last week.

@grahamwhaley
Copy link
Copy Markdown
Contributor Author

grahamwhaley commented Jan 14, 2019

Given this PR cannot break the CIs afaict, and we know what the CI errors are (unrelated to this), if nobody objects - can we merge this so I can get on testing #137 against the github CODEOWNERS ack methods?

@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Jan 14, 2019

/me leans on the button and looks whistles nonchalantly...

@jodh-intel jodh-intel merged commit 39d5205 into kata-containers:master Jan 14, 2019
This was referenced Jan 30, 2019
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chavafg chavafg chavafg approved these changes

@jodh-intel jodh-intel jodh-intel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grahamwhaley @jodh-intel @caoruidong @chavafg