Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

kernel: Enable virtio-fs in kata kernel#484

Merged
grahamwhaley merged 1 commit intokata-containers:masterfrom
ganeshmaharaj:virtio-fs-4-19-28
May 7, 2019
Merged

kernel: Enable virtio-fs in kata kernel#484
grahamwhaley merged 1 commit intokata-containers:masterfrom
ganeshmaharaj:virtio-fs-4-19-28

Conversation

@ganeshmaharaj
Copy link
Copy Markdown
Contributor

This patches adds virtio-fs capability to the kata kernel along with
config changes to enable the same on kata by default. The system will
only be exercised when shared_fs is set to virtio-fs in the kata
configuration file. the default still remains to be 9p

Fixes: #387

Signed-off-by: Ganesh Maharaj Mahalingam ganesh.mahalingam@intel.com

@egernst
Copy link
Copy Markdown
Member

egernst commented May 6, 2019

/test

Copy link
Copy Markdown
Contributor

@chavafg chavafg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,7 +1,7 @@
From 074a6a9d83a4e790f892ef0fc91cdabbfbf26202 Mon Sep 17 00:00:00 2001
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this patch, now we have 3 patches that start with 0001, would you mind changing their name?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change actually renames all the patches to have a proper order. Do you think i have missed it?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops!, yes, you're right 😄

This patches adds virtio-fs capability to the kata kernel along with
config changes to enable the same on kata by default. The system will
only be exercised when `shared_fs` is set to `virtio-fs` in the kata
configuration file. the default still remains to be 9p

Fixes: kata-containers#387
Depends-on: github.com/kata-containers/runtime#1016

Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
@ganeshmaharaj
Copy link
Copy Markdown
Contributor Author

/retest

chavafg added a commit to chavafg/tests-1 that referenced this pull request May 6, 2019
Add configuration option to use virtio-fs.
We will currently use nemu for testing the
virtio-fs support.

Depends-on: github.com/kata-containers/runtime#1016
Depends-on: github.com/kata-containers/packaging#484

Fixes: kata-containers#1536.

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>

#
# Compiler: gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609
# Compiler: gcc (Ubuntu 7.4.0-1ubuntu1~16.04~ppa1) 7.4.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOI, why are you using a ppa (non-standard) compiler version?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess - only way to get a recent gcc on bunty...

@jodh-intel
Copy link
Copy Markdown

We'd better get Mr Fragment^w^w @grahamwhaley to ack this one too... 😄

# CONFIG_FUSE_FS is not set
CONFIG_FUSE_FS=y
# CONFIG_CUSE is not set
CONFIG_VIRTIO_FS=y
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these two CONFIG items are only present with the patches in this PR (that is, they are not upstream yet afaict), we can't apply them to the fragments PR until this PR has landed.
They look find in the context of this PR though.

@grahamwhaley
Copy link
Copy Markdown
Contributor

This is ready to merge - we should probably bring this PR to the attention of @stefanha and @dagrh for a moment before we merge though :-)

chavafg added a commit to chavafg/tests-1 that referenced this pull request May 7, 2019
Add configuration option to use virtio-fs.
We will currently use nemu for testing the
virtio-fs support.

Depends-on: github.com/kata-containers/runtime#1016
Depends-on: github.com/kata-containers/packaging#484

Fixes: kata-containers#1536.

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
@stefanha
Copy link
Copy Markdown

stefanha commented May 7, 2019

@grahamwhaley @ganeshmaharaj The config options look good.

@grahamwhaley
Copy link
Copy Markdown
Contributor

Great, let's merge this puppy...

@grahamwhaley grahamwhaley merged commit 4bb97ef into kata-containers:master May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package a kernel with virtio-fs patches

7 participants