Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

docs: Add Debian 10 to distro table#585

Merged
amshinde merged 1 commit intokata-containers:masterfrom
jodh-intel:add-debian-10
Jan 22, 2020
Merged

docs: Add Debian 10 to distro table#585
amshinde merged 1 commit intokata-containers:masterfrom
jodh-intel:add-debian-10

Conversation

@jodh-intel
Copy link
Copy Markdown

Now that [1] has landed, update the list of supported distros to include
Debian 10.

[1] - kata-containers/packaging#647

Fixes: #584.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

Now that [1] has landed, update the list of supported distros to include
Debian 10.

[1] - kata-containers/packaging#647

Fixes: kata-containers#584.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel jodh-intel requested a review from a team as a code owner January 20, 2020 09:38
@jodh-intel
Copy link
Copy Markdown
Author

Replaces #577 which hasn't been updated in a while.

@jodh-intel jodh-intel mentioned this pull request Jan 20, 2020
Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grahamwhaley
Copy link
Copy Markdown
Contributor

CI spell check fail @jodh-intel - I'm sort of hoping it was not due to kata-containers/tests#2228
CI logs are loooong though.... any thoughts?

@jodh-intel
Copy link
Copy Markdown
Author

@grahamwhaley - Ufortunately, I think it is failing due to your PR, yes.

Since that script runs with set -e and since none of the spell checks failed the function is ending with:

[ $docs_failed -ne 0 ] && die ...

which expands to:

[ 0 -ne 0 ] && die ...

which expands to:

false && die ...

So since that function is returning false (1), the script just aborts at that point. If you change that line to the following I think it will work:

[ $docs_failed -ne 0 ] && die "..." || true

@grahamwhaley
Copy link
Copy Markdown
Contributor

ack. see kata-containers/tests#2240
I wonder, can we test that with this PR with a depends on ??

@chavafg
Copy link
Copy Markdown
Contributor

chavafg commented Jan 21, 2020

/test-ubuntu

@amshinde amshinde merged commit 4d47c3f into kata-containers:master Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Debian 10 to list of available distros

5 participants