This repository was archived by the owner on May 12, 2021. It is now read-only.
CI: Pin Travis golang version#282
Merged
jodh-intel merged 1 commit intokata-containers:masterfrom Oct 23, 2018
Merged
Conversation
Author
|
It's unclear whether you can just specify a go version in Let's see what happens... |
7dbfe64 to
558dd7c
Compare
Travis appears to be providing a version of golang that is too old for https://mvdan.cc/xurls/cmd/xurls, which is used by the CI scripts in the tests repo. See: - kata-containers/runtime#744 - kata-containers/tests#843 (comment) Required adding a NOP makefile to avoid Travis from trying to build this repo using `go`. Fixes kata-containers#281. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
3de1f97 to
b40b9ff
Compare
Contributor
|
green @jodh-intel ! |
Author
|
Tis, but I don't see any acks?!? Pretty please... :) |
grahamwhaley
approved these changes
Oct 23, 2018
Contributor
grahamwhaley
left a comment
There was a problem hiding this comment.
Heh, Makefile!
lgtm
Author
|
Ta! ;) |
This was referenced Oct 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis appears to be providing a version of golang that is too old for
https://mvdan.cc/xurls/cmd/xurls, which is used by the CI scripts in the
tests repo.
See:
Fixes #281.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com