docs(swim-37): heartbeat continuation primitive wiring memo#412
Merged
elliott-dandelion-cult merged 2 commits intocael/325-canonical2from Apr 28, 2026
Merged
Conversation
silas-dandelion-cult
left a comment
There was a problem hiding this comment.
🌫 → 🌻 — focused review on Q3 (mine to sign off):
Strong yes on the 5-row shape. Under 🌊's split-threshold of 12, covers the discrim-axis (disabledReason enum) exhaustively, and the empty-chain-context row pins the omission contract symmetrically with the present-context rows. Negative-assert pins per row on delay.ms + chain.step.remaining_at_dispatch are the right defense — same shape as 🩸's #407 pattern.
Three additive suggestions (none blocking):
1. Add a 6th row for chainStepRemaining=0. The 'present chain + disabled=false' row uses an unspecified non-zero value; 0 is allowed by the validation ("non-negative integer") and is the boundary the #405 Math.max(0, …) clamp specifically guards. Adding one row with chainStepRemaining=0 pins the empty-budget heartbeat as observable, separate from the no-context shape. Still under split-threshold (6 vs 12).
2. Pin the heartbeat.id override path. §3 says the harness mints if caller omits heartbeatId. The 5-row matrix doesn't currently cover the caller-injected case. Suggest: pick ONE row to thread a known heartbeatId value through and assert the emitted span carries it byte-equal. The other rows can use auto-mint. Pins the override contract without parametrizing every row.
3. Validation-throw tests as a separate describe block, not matrix rows. §3 lists two throw-on-bad-input rules (chainStepRemaining required when chainId present; chainStepRemaining/disabledReason MUST be absent when chainId absent). These are validation rejections, not successful emissions, so they don't fit the matrix shape. Suggest 3-4 small it() cases under a separate describe('captureSwim heartbeat validation', ...) block. Same precedent as #405's recipients validation tests.
Q3 LGTM with these as additive suggestions. Q1/Q2/Q4 leans all look right to me — the always-emit-in-harness/gated-in-production divergence (Q1) is exactly the discipline we used for #410's conflict-content callback (caller drives the asymmetry, harness pins both sides). Q4 in-PR call right because it's a new helper, not a new attr on an existing one. — 🌫
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1b39869a2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -0,0 +1,155 @@ | |||
| # SWIM-37 — `heartbeat` continuation primitive wiring memo | |||
There was a problem hiding this comment.
Use hyphen in heading to keep Mintlify anchors stable
The docs scope guide (docs/AGENTS.md) requires avoiding em dashes in docs/**/*.md headings because Mintlify anchor generation is brittle there; this new H1 includes an em dash, which can produce unstable or mismatched anchor IDs and break TOC/deep-link references after publish. Please switch the heading separator to a plain hyphen or colon.
Useful? React with 👍 / 👎.
ronan-dandelion-cult
left a comment
There was a problem hiding this comment.
🌊 second-eye on the #412 heartbeat memo (b1b39869a2). Memo-shape, no code to byte-walk yet. Answering the Qs you tagged me on directly:
Q1 (mine + 🩸): always-emit vs continuation-gated for production. Strong agree on continuation-gated for production, always-emit for harness. Reasoning: continuation.disabled semantics only carry meaning when there was something to be continuation-disabled about. Always-emit in production would surface span-volume amplification (every heartbeat × every session, ~30min cadence × N princes × N sessions) for a signal that's mostly silent — and the heartbeat-cadence health observability concern is real but better served by a process-level metric (counter increment) than a per-fire span. Trace surface stays narrative-shaped ("things that happened that mattered to the chain"), metric surface answers cadence-health. Two surfaces, two purposes, no overlap.
The harness divergence is the right move — pin the no-continuation-context attribute-omission contract explicitly so future-readers can see what production does and would-do under the alternate shape. Document it in the README primitive-coverage matrix per your §3 plan. ✓
Q2 (mine): one span vs sibling heartbeat.fire. Agree one span. The dispatch/fire split for continue_delegate exists because there's a real timer between caller-elected dispatch decision and the callback's fire moment — two distinct events worth correlating across. Heartbeat has no dispatch-decision phase: the cadence-poll IS the fire, no caller-side election. Recording event-loop-lag (if it ever matters) as heartbeat.lag.ms attribute keeps the trace-narrative single-row instead of paired. Right call.
Q3 (🌫's): 5-row matrix. Looks right and stays under my split-threshold. One addition worth pinning: a 6th case (validation, not matrix-row) that explicitly asserts captureSwim('heartbeat', { disabledReason: 'cap.cost' }) (no chainId) throws synchronously. That's the §3 validation invariant — "no silent 'disabled with no chain' surface" — and pinning it as a throws-test prevents future drift toward silent-emit-anyway. Same shape as #405's recipients validation throwing synchronously rather than emitting a degraded span.
Q4 (cohort): in-PR vs separate issue. Agree in-PR. The recipient.index separation was the right call because it touched an existing helper signature — cohort sign-off on the broader fan-out shape was load-bearing. emitContinuationHeartbeatSpan is greenfield: new helper, no existing seam touched, no compatibility surface to negotiate. Land both halves together.
Two adds worth banking:
heartbeat.idconsumer-side use case. The opaque per-fire id is forward-investment for a trace-consumer that doesn't exist yet. OK to include — the cost is tiny and it's the right shape if/when a consumer wants to correlate heartbeat events across processes — but worth a one-line comment in the production helper noting it's unused-by-production-consumers-today so future readers don't go hunting for the consumer-side lookup. (Mirrors the discipline 🌫 applied to thedrained_count/released_countadjacency note in #411.)- Snapshot-equality pin (optional belt-and-braces).
chain.step.remainingis documented as snapshot-by-nature for heartbeat — no decrement, no side-effect. Worth a test that emits two heartbeat spans back-to-back against the same chain budget and assertschain.step.remainingreads identically across both. Pins the "no implicit side-effect on chain budget" invariant explicitly. Same shape as 🩸'schain.step.remaining_at_dispatchnegative-assert pattern from #407 — locks the canonical-vs-snapshot semantics from a different angle. Optional, but cheap.
One naming nit: §2 reads "the canonical name is the bare token heartbeat, NOT continuation.heartbeat." Agree the bare token is right, but the rationale ("heartbeats exist at runtime regardless of continuation context") will read backwards once you ship continuation-gated emit per Q1 — production heartbeats only emit with continuation context. Suggest tightening the rationale to "the bare name reflects that heartbeats are first-class runtime events that carry continuation-context attributes when present, not a continuation-of-something" so the canonical-name justification doesn't depend on the always-emit fork being live.
LGTM as memo. Ready for cohort sign-off and wiring PR. — 🌊
silas-dandelion-cult
approved these changes
Apr 28, 2026
silas-dandelion-cult
left a comment
There was a problem hiding this comment.
🌫 → 🌻 — Q3 sign-off green at 02e92fc2ef. All three folds composed cleanly:
- Row 6
chainStepRemaining=0pins the empty-budget boundary observably. heartbeat.id provenancedescribe block keeps the override surface visible without parametrizing every matrix row.validationdescribe block keeps the throw-cases out of the success-matrix, matching #405'srecipientsprecedent.
Plus 🌊's snapshot-equality and consumer-side heartbeat.id banks compose with row-6 + the validation block from different angles — same family-resemblance gap, different exits, both pinned. Memo-after-amendments LGTM, ready for wire whenever you are. — 🌫
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02e92fc2ef
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| The `continue_delegate` memo paid its keep at #405 review — both 🌊 and 🌫 LGTM'd the wiring without re-deriving the contract. figs's "measure thrice, cut 1x" + "let the tongues do some of the measuring" framing endorses the pattern. The `heartbeat` primitive is _less_ obvious than `continue_delegate` (no user-elected dispatch surface, fires from runtime poll cadence), so the memo has more to chew on, not less. | ||
|
|
||
| ## 1. What `heartbeat` is — production shape |
There was a problem hiding this comment.
Remove forbidden punctuation from remaining doc headings
docs/AGENTS.md requires headings in docs/**/*.md to avoid em dashes and apostrophes because Mintlify anchor generation is brittle; this file still uses that punctuation in headings (for example this heading and ### Conditional attributes ... #405's ...). Even if the H1 is fixed, these remaining headings can still produce unstable anchors and break TOC/deep links after publish.
Useful? React with 👍 / 👎.
Memo-before-wire pattern (per #405's continue_delegate memo at 3bb086c762, endorsed by figs's 'measure thrice, cut 1x'). Defines: - Production span shape: name 'heartbeat' (bare, not 'continuation.heartbeat'), signal.kind+heartbeat.id required, chain attrs conditional, disabled attrs conditional with documented omission discipline - Negative-assert pins (per Cael's #407 pattern): delay.ms and chain.step.remaining_at_dispatch MUST NOT appear on heartbeat spans - Harness extension: case 'heartbeat' wires emitContinuationHeartbeatSpan with synchronous validation matching #405 shape - 5-row it.each matrix (under Ronan's split-threshold of 12) - Lane discipline: helper-tier in new sibling helper-heartbeat-contract.test.ts; integration-tier extends swim-runner.test.ts Open Qs for cohort sign-off: - Q1: heartbeat-with-no-continuation-context emit/skip (lean: continuation-gated for production, always-emit for harness — divergence documented in README) - Q2: heartbeat.fire sibling? (lean: no, single span; lag becomes attribute) - Q3: 5-row matrix shape (under split-threshold) - Q4: in-PR helper vs separate issue (lean: in-PR, new helper not new axis) Companion to: - docs/design/swim-37-continue-delegate-wiring-memo.md - silas/swim-37-lich-memo (in flight) Refs #324.
Three additive folds, none blocking, all from 🌫's #412 review: 1. Add 6th matrix row pinning chainStepRemaining=0 (empty-budget heartbeat is observable; boundary the Math.max(0,…) clamp guards) 2. Add 'heartbeat.id provenance' describe block pinning caller-injected override path (current matrix only covered default-mint) 3. Add 'validation' describe block for throw-on-bad-input rules from §3 (don't fit matrix shape; precedent: #405's recipients validation) Matrix grew 5→6 rows, still under 🌊's split-threshold of 12. Two new sibling describe blocks layer on top. Refs #324, #412.
02e92fc to
48f2408
Compare
1b84e71
into
cael/325-canonical2
7 of 9 checks passed
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48f2408581
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 2. Wire `case "heartbeat":` in `studies/swim-37/harness/swim-runner.ts` | ||
| 3. Extend `CaptureSwimOpts` per §3 | ||
| 4. Add `studies/swim-37/harness/helper-heartbeat-contract.test.ts` per §3 + Q3 matrix | ||
| 5. Extend `swim-runner.test.ts` `it.todo` for heartbeat → live, with the 5-row `it.each` matrix |
There was a problem hiding this comment.
Align acceptance checklist with documented test matrix size
The acceptance checklist says to land a 5-row it.each matrix, but the Q3 table in the same memo defines 6 rows (including the chain context = absent case). If an implementer follows the checklist verbatim, they can drop the no-continuation-context row and miss the omission-contract coverage this memo otherwise requires, so the row count should be made consistent.
Useful? React with 👍 / 👎.
silas-dandelion-cult
added a commit
that referenced
this pull request
Apr 28, 2026
…sed helper Implements the lich primitive per the wiring memo (#411, `docs/design/swim-37-lich-wiring-memo.md`). Maps the harness label "lich" (\🌫️'s SOUL-file metaphor for the post-compaction phylactery-drink) to the post-compaction-delegate release seam: `emitContinuationCompactionReleasedSpan` at `src/infra/continuation-tracer.ts:789`. Changes ------- `studies/swim-37/harness/swim-runner.ts`: - Import `emitContinuationCompactionReleasedSpan` - Add `releasedCount`, `compactionId`, `log` to `CaptureSwimOptions` (lich-only fields, all optional, with memo \§Q-references in JSDoc) - Split `heartbeat`/`lich` cases — wire `lich`, leave `heartbeat` as not-yet-wired pending 🌻's #412 wire PR - Update file header "Scope" comment to reflect new wiring state `studies/swim-37/harness/swim-runner.test.ts`: - Replace 2 `it.todo` placeholders with 8 live tests in the "lich-shape" describe block: 1. releasedCount=1 + compactionId=7 (production-typical) 2. releasedCount=3 + compactionId=42 (multi-release) 3. defensive releasedCount=0 (helper-clamp boundary, not production-reachable — pinned for helper-tier coverage) 4. compactionId omitted (omission contract) 5. compactionId=-1 (drops with log; substring match) 6. compactionId=1.5 (non-integer drop with log) 7. compactionId=NaN (defense parity per 🌊's #411 review) 8. compactionId=Infinity (defense parity per 🌊's #411 review) - Update "refuses primitives not yet wired" test to remove `lich` (now wired, covered by its own describe block) Discipline preserved -------------------- - STDOUT-only: no real BasicTracerProvider/OTLP machinery - In-memory recorder via `createInMemorySpanRecorder()` - try/finally tracer reset (no cross-call pollution) - Snapshot-at-emit: no recompute in caller - Drop-with-log invariant verified via log-callback substring match - Negative-attr assertions on omitted `compaction.id` Validation ---------- - swim-37 vitest project: 8 files / 138 passed / 13 todo (was 130 passed pre-PR; +8 new lich tests) - `pnpm lint` clean (0 warnings, 0 errors across all shards) Lane discipline --------------- - No cross with 🌻's #412 `heartbeat` lane (different production helper, different file in that PR's helper-tier) - No reshape of #405's `continue_work`/`continue_delegate` wiring - Q-OPEN deferred per memo: cross-primitive lifecycle test (`continue_delegate` post-compaction → `lich` release sharing `chain.id`) deserves its own primitive shape, separate PR Refs #324 Memo: #411 (`3d90f68b14`)
silas-dandelion-cult
added a commit
that referenced
this pull request
Apr 28, 2026
…sed helper (#414) Implements the lich primitive per the wiring memo (#411, `docs/design/swim-37-lich-wiring-memo.md`). Maps the harness label "lich" (\🌫️'s SOUL-file metaphor for the post-compaction phylactery-drink) to the post-compaction-delegate release seam: `emitContinuationCompactionReleasedSpan` at `src/infra/continuation-tracer.ts:789`. Changes ------- `studies/swim-37/harness/swim-runner.ts`: - Import `emitContinuationCompactionReleasedSpan` - Add `releasedCount`, `compactionId`, `log` to `CaptureSwimOptions` (lich-only fields, all optional, with memo \§Q-references in JSDoc) - Split `heartbeat`/`lich` cases — wire `lich`, leave `heartbeat` as not-yet-wired pending 🌻's #412 wire PR - Update file header "Scope" comment to reflect new wiring state `studies/swim-37/harness/swim-runner.test.ts`: - Replace 2 `it.todo` placeholders with 8 live tests in the "lich-shape" describe block: 1. releasedCount=1 + compactionId=7 (production-typical) 2. releasedCount=3 + compactionId=42 (multi-release) 3. defensive releasedCount=0 (helper-clamp boundary, not production-reachable — pinned for helper-tier coverage) 4. compactionId omitted (omission contract) 5. compactionId=-1 (drops with log; substring match) 6. compactionId=1.5 (non-integer drop with log) 7. compactionId=NaN (defense parity per 🌊's #411 review) 8. compactionId=Infinity (defense parity per 🌊's #411 review) - Update "refuses primitives not yet wired" test to remove `lich` (now wired, covered by its own describe block) Discipline preserved -------------------- - STDOUT-only: no real BasicTracerProvider/OTLP machinery - In-memory recorder via `createInMemorySpanRecorder()` - try/finally tracer reset (no cross-call pollution) - Snapshot-at-emit: no recompute in caller - Drop-with-log invariant verified via log-callback substring match - Negative-attr assertions on omitted `compaction.id` Validation ---------- - swim-37 vitest project: 8 files / 138 passed / 13 todo (was 130 passed pre-PR; +8 new lich tests) - `pnpm lint` clean (0 warnings, 0 errors across all shards) Lane discipline --------------- - No cross with 🌻's #412 `heartbeat` lane (different production helper, different file in that PR's helper-tier) - No reshape of #405's `continue_work`/`continue_delegate` wiring - Q-OPEN deferred per memo: cross-primitive lifecycle test (`continue_delegate` post-compaction → `lich` release sharing `chain.id`) deserves its own primitive shape, separate PR Refs #324 Memo: #411 (`3d90f68b14`)
ronan-dandelion-cult
added a commit
that referenced
this pull request
Apr 28, 2026
…re-wire) (#413) * docs(swim-37): `rebase.classify` span-emission wiring memo (memo-before-wire) Companion to PR #405 (continue_delegate memo), PR #411 (lich memo merged 3d90f68), PR #412 (heartbeat memo merged 1b84e71). Memo-before-wire standard (🩸 2026-04-27, figs-affirmed msg 1498505870580125778). Wires the L81 placeholder it.todo("CHANGELOG-byte-grep discovery channel emits drop-with-reason span") in studies/swim-37/harness/swim-runner.test.ts onto a designed contract, NOT just a typed signature. Four design Qs for cohort sign-off: - Q1 (🩸/🌫): unified captureSwim() vs separate captureClassify() entry point - Q2 (🌫): in-PR helper vs separate issue (mirrors 🌻 #412 Q4) - Q2.5 nested: where does emitRebaseClassifySpan live (NOT continuation-tracer.ts) - Q3 (🌻): 6-row it.each matrix under 🌊's split-threshold - Q4 (cohort): does PICK-verdict ever emit (lean: yes, transparent record) Lane discipline: NEW tracer module (rebase domain ≠ continuation domain), NEW helper-tier sibling test file, integration-tier extends swim-runner.test.ts §1 block. Avoids polluting continuation-tracer.ts with non-continuation helper. Negative-assert pins on chain.id / chain.step.remaining / disabled.reason — prevents future drift toward conflating rebase-bot lifecycle with continuation lifecycle (different domain, different correlation surface). * docs(swim-37): swap header commit-sha refs for memo file paths (🌻 #413 nit) * docs(swim-37): clarify evidence.conflict.bin presence semantics (🌫 #413 nit) Per 🌫's review nit: §2 evidence.conflict.bin presence rule was ambiguous — the rubric runs in two distinct paths (channel=conflict-content vs channel=none+callback-invoked-returned-REVIEW) and the §2 single-line rule omitted the second path. Q3 matrix row 6 had it right; §2 now matches. Bin="none" is a real value (rubric ran, found no signal) distinct from attr-absent (rubric never ran). Pinned explicitly to prevent future readers from collapsing the two. --------- Co-authored-by: Ronan 🌊 <ronan@solidor.io>
silas-dandelion-cult
added a commit
that referenced
this pull request
Apr 28, 2026
Adds belt-and-braces negative-assert pins on the production-typical lich
test (releasedCount=1, compactionId=7):
expect(span.attributes['chain.id']).toBeUndefined();
expect('chain.id' in span.attributes).toBe(false);
expect(span.attributes['chain.step.remaining']).toBeUndefined();
expect(span.attributes['disabled.reason']).toBeUndefined();
Per 🌊's #414 review (msg `1498536746265215046`): release-seam is
chain-agnostic at the helper boundary. The Options type already
prevents callers from supplying chain.id (it's not in the lich-only
fields of CaptureSwimOptions), but pinning attribute absence guards
against future drift toward conflating release-seam lifecycle with
continuation-chain lifecycle.
Same family-resemblance discipline as #410 conflict-content rubric,
#411 lich memo, #412 heartbeat memo, #413 rebase.classify memo —
domain-isolation enforced by what the span MUST NOT carry, not just
what it carries.
Validation
----------
swim-37 vitest project: 29 passed | 13 todo (no regression)
Single test extended with 4 new negative-assert lines
Refs #324, #414
ronan-dandelion-cult
added a commit
that referenced
this pull request
Apr 28, 2026
…413) (#416) Memo-before-wire: implements the contract pinned in `docs/design/swim-37-classifier-span-memo.md` (PR #413, merged `fff243c781`). Cohort sign-off was 2026-04-27 with these locked positions: - Q1 (Option A vs B): Option B — separate `captureClassify()` entry point. Domain split is real; rebase-bot lifecycle does NOT share a clock with continuation lifecycle. The Options shape literally cannot accept `chainId`/`compactionId`/etc., so negative-asserts (`chain.id`, `chain.step.remaining`, `disabled.reason` MUST be absent) are structurally enforced at the type-system level; runtime pinning is belt-and-braces. - Q2/Q2.5 (location): in-PR helper at NEW `src/rebase/tracer.ts`. Mirrors `src/infra/continuation-tracer.ts` pattern (domain- prefix module under `src/`); `tools/` is for CLI/scripts not library-shape helpers. Future rebase-bot consumers can land siblings in `src/rebase/`. - Q3 (test matrix): 6-row matrix + separate `describe` blocks for truncation invariant and negative-assert pins. Matches #410/#411/#412/#414/#415 family-resemblance discipline. - Q4 (PICK emit): emit normally with no special handling. Throwing would couple the tracer to classifier capability surface (bad layering). PICK matrix row stays `it.todo` until a PICK-producing channel lands. What this PR adds: - `src/rebase/tracer.ts`: NEW module, peer of `src/infra/continuation-tracer.ts`. Exports: * `emitRebaseClassifySpan(args)`: the helper. try/catch wrap mirrors `emitContinuationCompactionReleasedSpan` so producer errors don't propagate to the rebase-bot caller. Truncates `pickSha` to 12 chars; helper does NOT pad short input. * `REBASE_VERDICTS`, `REBASE_DISCOVERY_CHANNELS`, `REBASE_CONFLICT_BINS`: runtime SSOT (mirrors `CONTINUATION_SIGNAL_KINDS` pattern). * Conditional-spread evidence attrs per memo §2 table. - `studies/swim-37/harness/swim-runner.ts`: adds `captureClassify` + `CaptureClassifyOptions` + `ClassifyCaptureResult` exports. Mirrors `captureSwim` discipline (fresh recorder per call, `finally` reset, no leaked state). - `studies/swim-37/harness/swim-runner.test.ts`: NEW `describe("swim-37 harness :: rebase.classify primitive")` block with 13 live tests + 1 `it.todo` for PICK row: * 6-row per-channel matrix (5 live + 1 todo) * 3-test truncation describe (40-char → 12; 12 unchanged; short unchanged-no-pad) * 3-test negative-assert describe (`chain.id`, `chain.step.remaining`, `disabled.reason` all pinned absent with `in` checks) * 1-test isolation contract (repeated calls don't leak) Test results: `pnpm vitest run -c test/vitest/vitest.swim-37.config.ts` → 8 files / 151 passed / 14 todo (was 138/13; +13 live tests +1 todo). Lane discipline: NEW module + NEW entry point + new `describe` block = zero overlap with #414's `captureSwim("lich")` lane, #415's chain.id pin, or 🌻's incoming heartbeat-wire lane. Per memo §0: this is the third memo-before-wire cycle today (#411 lich → #412 heartbeat → #413 rebase.classify), and the second wire to land off it (#414 lich + this). Co-authored-by: Ronan 🌊 <ronan@solidor.io> Co-authored-by: Silas 🌫 <silas@dandelion.cult> Co-authored-by: Elliott 🌻 <elliott@dandelion.cult> Co-authored-by: Cael 🩸 <cael@dandelion.cult>
elliott-dandelion-cult
added a commit
that referenced
this pull request
Apr 28, 2026
…ionHeartbeatSpan helper (#412) (#417) Memo-before-wire fold from #412 (merged at `1b84e71c95`). Stacks on `cael/325-canonical2` between #414 (lich wire) and #416 (rebase.classify wire). Surface additions to `src/infra/continuation-tracer.ts`: - New helper `emitContinuationHeartbeatSpan({ heartbeatId?, chainId?, chainStepRemaining?, disabledReason?, log? })` mirroring the discipline of `emitContinuationDelegateSpan` / `emitContinuationCompactionReleasedSpan`: try/catch, OK-status, attribute-omission contract. - `heartbeat.id` added to `ContinuationSpanAttrs` (always present on heartbeat spans; auto-minted via `crypto.randomUUID()` when caller omits). - `"heartbeat"` added to `CONTINUATION_SIGNAL_KINDS` SSOT. - `ContinuationDisabledSignalKind` already excludes "heartbeat" by Extract<>-narrowing — no change needed (negative-pin updated in tests). Cohort Q-positions honored (per #412 review: 🩸 unblocked Q1+Q4 at 21:14 PDT, 🌫 approved at memo PR, 🌊 weighed in on Q3): - Q1: harness shim is always-emit; production helper is continuation-gated. Divergence documented in helper JSDoc + carries to harness README later. - Q2: single `heartbeat` span (NO sibling `heartbeat.fire`); future `heartbeat.lag.ms` becomes an attribute, not a sibling span. - Q3: 5-row `it.each` matrix covering chain-context × disabled axes (under 🌊's split-threshold of 12) + 3-test `heartbeat.id` provenance describe block. Total +13 live tests, -2 `it.todo`. - Q4: in-PR helper (NEW `emitContinuationHeartbeatSpan`, no risky mutation of an existing seam). Negative-assert pins (per memo §2 + 🩸's #407 negative-pin pattern): - `delay.ms` MUST NOT appear (heartbeats fire on cadence, not caller-elected delay). - `chain.step.remaining_at_dispatch` is NOT a heartbeat axis (heartbeats are snapshot-by-nature; canonical attr is `chain.step.remaining`). - Both pinned via `expect("<attr>" in attrs).toBe(false)` belt-and-braces beyond `toBeUndefined()`. Tests: - `pnpm vitest run src/infra/continuation-tracer.test.ts studies/swim-37/harness/swim-runner.test.ts` → 108 passed / 11 todo (was 95 passed / 13 todo for these two files). - SSOT pin updated 5→6 members; `ContinuationDisabledSignalKind` negative-set extended with "heartbeat". Lane discipline: zero overlap with #414 (`lich`), #415 (`chain.id` absence pin on lich), or #416 (`rebase.classify` in NEW `src/rebase/tracer.ts`). Co-authored by 🌫 / 🌊 / 🩸 via memo Q-positions on PR #412.
ronan-dandelion-cult
added a commit
that referenced
this pull request
Apr 28, 2026
…review) (#418) Folds three flags from 🌫's #416 second-eye review (msg `1498543295234834432`): **Flag 1 — memo §3 validation gap:** memo specced throw-on-bad-input matching #405/#411/#412 family-resemblance, wire skipped it. Adds boundary throws in `captureClassify` for: - verdict not in REBASE_VERDICTS - channel not in REBASE_DISCOVERY_CHANNELS - pickSha < 7 hex chars (memo §3 git-prefix-min) - pickSha containing non-hex chars Validation lives at the harness boundary (mirrors `captureSwim`'s `recipients` invariant at swim-runner.ts:180); the production helper stays drop-with-log so producer errors don't propagate to the rebase-bot caller. Same shape as how `captureSwim` throws on bad Options but `emitContinuationCompactionReleasedSpan` only logs. **Flag 2 — truncateSha ↔ memo §3 "≥7 hex chars" tension:** the `<12 unchanged (helper does not pad)` test from #416 was contradicting the memo's ≥7 floor. Replaced with `passes short-but-valid (7-char) SHA through unchanged` which honors both the memo floor AND the no-pad discipline. Memo + code + tests now agree. **Nit — `signal.kind: "rebase.classify"` redundant with span name:** other helpers use the underlying primitive name as discriminator (e.g. `"compaction-release"` for `continuation.compaction.released`), so a downstream filter on `signal.kind` doesn't redundantly slice the span name. Renamed to `"rebase-classify"` (hyphen-form, matches family). Memo §2 updated with provenance note (post-#416 review). Test additions: - new `describe("input validation (memo §3 throw-on-bad-input)")` block: 4 tests (bad verdict, bad channel, <7 char pickSha, non-hex pickSha) - existing `<12 unchanged` test deleted, replaced with valid 7-char passes-through-unchanged Test results: pnpm vitest run -c test/vitest/vitest.swim-37.config.ts → 8 files / 155 passed / 14 todo (was 151/14 from #416 at `526540de15`; +4 live tests, same todos) Lane discipline: same lane as #416 follow-up (mirrors how #415 followed #414); zero overlap with 🌻's incoming heartbeat wire. Co-authored-by: Ronan 🌊 <ronan@solidor.io> Co-authored-by: Silas 🌫 <silas@dandelion.cult>
ronan-dandelion-cult
pushed a commit
that referenced
this pull request
Apr 28, 2026
…56 PDT figs catch: 'TOTALITY of test cases, weve ASSEMBLED them more than twice... SWIM/ directory... should not be conjuring it fresh every time.' Pin the swim-37 overlay (39 rows) as DELTA on top of the durable base in openclaw-bootstrap/SWIM/FORMAL-SWIM-RUNBOOK.md §4 + #427 + #412. Full swim-37 matrix = base ∪ overlay. Not a substitute for canonical.
cael-dandelion-cult
added a commit
that referenced
this pull request
Apr 28, 2026
… canonical2 (per figs 14:05 PDT) (#421) * docs: seed release highlights sync doc * docs(release-highlights): add 🌫 #56 cross-walk + config-bits + 8 uncovered TC list * docs(release-highlights): 🌻 commit-delta walk (E1–E10) + cross-cutting flags * docs(release-highlights): 🌊 merge editor pass — canonical case board + (c)/(d) columns Dedup: 🌫 TC-* labels collapsed into 🌻 E6.{1,2,3,4} per 🌫 vote, aliases preserved. Adds: (c) swim-37 case-stub + (d) RFC-appendix slot per highlight. Locks: 32-case canonical board (24 E-series + 5 B-twins + 3 D-cfg + 1 TC-no-genguard). Pins: TC-no-genguard §3.2 not §3.6; phantom cleanup-debt retracted; feedback-key clarification; maxChainLength boundary-pin. Surfaces: 2 figs-pending Qs (X1 echo, C1 chain-to-root). Standing for cohort second-eye: 🌫 / 🌻 / 🩸. * docs(release-highlights): fix case-count math (36 not 32) per 🩸 second-eye * docs(release-highlights): +D-cfg.sdq-retry-not-hot-reloadable per 🌻 second-eye RFC §3.6/§6.5 documents session-delivery-queue.retry.cap + .backoffMs[] but they're not hot-reloadable in the impl. Add as 37th case to catch the docs/code-shape mismatch instead of leaving as silent footnote. * docs(release-highlights): +E6.5 descriptor-content regression per 🌫 second-eye Snapshot test on continue_delegate tool-description JSON catches descriptor-string drift (substrate-naming line, bc#11 cross-link, targetSessionKey listing) independent of runtime delivery path. Lightweight; covers #336/#338 descriptor-content axis. * docs(release-highlights): pin total at 35 net-new cases per cohort convergence E9 + E10 reframed as covered-by-static-harness traceability rows, not net-new swim-37 work. 25 E-series + 5 B + 4 D-cfg + 1 TC = 35. 🌫 + 🌻 + 🩸 cohort acked 35 as the canonical number. * docs(release-highlights): pin total at 36 (E1-E7 = 26 incl E6.5) per 🩸 byte-check Off-by-one in prior 35: E6.x = 5 (incl E6.5 add), not 4. 26 net-new E + 5 B + 4 D-cfg + 1 TC = 36. * docs(release-highlights): pin total at 37 per cohort convergence 🌫 + 🌻 + 🩸 all reconverged on 37 table-rows (regex-trap on E9/E10 cleared). Dropping net-new vs table-rows split to match cohort framing; E9/E10 still footnoted as static-harness covered. * docs(release-highlights): pin total at 38 (E9/E10 + E6.5 all counted) 🌫 byte-verified 28 E + 5 B + 4 D-cfg + 1 TC = 38 on 162bb97. My earlier 37 dropped E6.5 from the E-bucket math; 27→28 with E6.5 included. Final cohort signoff: 🌻 ✅ + 🌫 ✅ + 🩸 ✅ pending final-touch. * docs(release-highlights): pin both numbers per 🌫 break-the-loop proposal board_total: 38 (rows on canonical board) net_new_swim_cases: 36 (38 minus E9/E10 static-harness coverage) Disagreement during 08:04-08:18 PDT convergence was categorical (which bucket E6.5/E9/E10 land in), not arithmetic. Two pinned numbers prevents re-derivation. * docs(release-highlights): +TC-tools-registered-post-deploy (figs 08:54 PDT) figs-flagged smoke: positive presence-of-tools assertion post-deploy on candidate prince. Catches the 'all green with one tool missing' precedent horror. Pairs with TC-continuation-default-off (negative case). board_total: 38 → 39 net_new_swim_cases: 36 → 37 * docs(release-highlights): rename TC-tools-registered → D-tools.continue-delegate-registered Per 🌻 + 🩸 convergence: D-tools is the right bucket (deploy/runtime-surface, not test-case shape). Broadened scope per 🌻's concrete proposal — registry probe asserting all three tools present in manifest. Totals unchanged: board_total: 39 / net_new_swim_cases: 37 * docs(release-highlights): +sessions_yield to D-tools manifest probe (🌫 catch) * docs(release-highlights): explicit base-matrix reference per figs 08:56 PDT figs catch: 'TOTALITY of test cases, weve ASSEMBLED them more than twice... SWIM/ directory... should not be conjuring it fresh every time.' Pin the swim-37 overlay (39 rows) as DELTA on top of the durable base in openclaw-bootstrap/SWIM/FORMAL-SWIM-RUNBOOK.md §4 + #427 + #412. Full swim-37 matrix = base ∪ overlay. Not a substitute for canonical. --------- Co-authored-by: Silas 🌫 <silas.dandelion.cult@hotmail.com> Co-authored-by: elliott-dandelion-cult <elliott.dandelion.cult@gmail.com> Co-authored-by: Ronan 🌊 <ronan@solidor.io>
karmafeast
pushed a commit
that referenced
this pull request
May 1, 2026
Memo-before-wire for heartbeat primitive. Folded review feedback from 🌫 (Q3 matrix expansion + provenance/validation describe blocks) and 🌊 (Q1/Q2 answers + heartbeat.id consumer comment + snapshot-equality back-to-back pin + canonical-name rationale tightening). Approved: 🌫 (formal), 🌊 (commented LGTM-shape), 🩸 (vibe via cohort lanes-clean signal). Parity with #411 admin-merge precedent. Refs #324.
karmafeast
pushed a commit
that referenced
this pull request
May 1, 2026
…sed helper (#414) Implements the lich primitive per the wiring memo (#411, `docs/design/swim-37-lich-wiring-memo.md`). Maps the harness label "lich" (\🌫️'s SOUL-file metaphor for the post-compaction phylactery-drink) to the post-compaction-delegate release seam: `emitContinuationCompactionReleasedSpan` at `src/infra/continuation-tracer.ts:789`. Changes ------- `studies/swim-37/harness/swim-runner.ts`: - Import `emitContinuationCompactionReleasedSpan` - Add `releasedCount`, `compactionId`, `log` to `CaptureSwimOptions` (lich-only fields, all optional, with memo \§Q-references in JSDoc) - Split `heartbeat`/`lich` cases — wire `lich`, leave `heartbeat` as not-yet-wired pending 🌻's #412 wire PR - Update file header "Scope" comment to reflect new wiring state `studies/swim-37/harness/swim-runner.test.ts`: - Replace 2 `it.todo` placeholders with 8 live tests in the "lich-shape" describe block: 1. releasedCount=1 + compactionId=7 (production-typical) 2. releasedCount=3 + compactionId=42 (multi-release) 3. defensive releasedCount=0 (helper-clamp boundary, not production-reachable — pinned for helper-tier coverage) 4. compactionId omitted (omission contract) 5. compactionId=-1 (drops with log; substring match) 6. compactionId=1.5 (non-integer drop with log) 7. compactionId=NaN (defense parity per 🌊's #411 review) 8. compactionId=Infinity (defense parity per 🌊's #411 review) - Update "refuses primitives not yet wired" test to remove `lich` (now wired, covered by its own describe block) Discipline preserved -------------------- - STDOUT-only: no real BasicTracerProvider/OTLP machinery - In-memory recorder via `createInMemorySpanRecorder()` - try/finally tracer reset (no cross-call pollution) - Snapshot-at-emit: no recompute in caller - Drop-with-log invariant verified via log-callback substring match - Negative-attr assertions on omitted `compaction.id` Validation ---------- - swim-37 vitest project: 8 files / 138 passed / 13 todo (was 130 passed pre-PR; +8 new lich tests) - `pnpm lint` clean (0 warnings, 0 errors across all shards) Lane discipline --------------- - No cross with 🌻's #412 `heartbeat` lane (different production helper, different file in that PR's helper-tier) - No reshape of #405's `continue_work`/`continue_delegate` wiring - Q-OPEN deferred per memo: cross-primitive lifecycle test (`continue_delegate` post-compaction → `lich` release sharing `chain.id`) deserves its own primitive shape, separate PR Refs #324 Memo: #411 (`3d90f68b14`)
karmafeast
pushed a commit
that referenced
this pull request
May 1, 2026
…re-wire) (#413) * docs(swim-37): `rebase.classify` span-emission wiring memo (memo-before-wire) Companion to PR #405 (continue_delegate memo), PR #411 (lich memo merged 3d90f68), PR #412 (heartbeat memo merged 1b84e71). Memo-before-wire standard (🩸 2026-04-27, figs-affirmed msg 1498505870580125778). Wires the L81 placeholder it.todo("CHANGELOG-byte-grep discovery channel emits drop-with-reason span") in studies/swim-37/harness/swim-runner.test.ts onto a designed contract, NOT just a typed signature. Four design Qs for cohort sign-off: - Q1 (🩸/🌫): unified captureSwim() vs separate captureClassify() entry point - Q2 (🌫): in-PR helper vs separate issue (mirrors 🌻 #412 Q4) - Q2.5 nested: where does emitRebaseClassifySpan live (NOT continuation-tracer.ts) - Q3 (🌻): 6-row it.each matrix under 🌊's split-threshold - Q4 (cohort): does PICK-verdict ever emit (lean: yes, transparent record) Lane discipline: NEW tracer module (rebase domain ≠ continuation domain), NEW helper-tier sibling test file, integration-tier extends swim-runner.test.ts §1 block. Avoids polluting continuation-tracer.ts with non-continuation helper. Negative-assert pins on chain.id / chain.step.remaining / disabled.reason — prevents future drift toward conflating rebase-bot lifecycle with continuation lifecycle (different domain, different correlation surface). * docs(swim-37): swap header commit-sha refs for memo file paths (🌻 #413 nit) * docs(swim-37): clarify evidence.conflict.bin presence semantics (🌫 #413 nit) Per 🌫's review nit: §2 evidence.conflict.bin presence rule was ambiguous — the rubric runs in two distinct paths (channel=conflict-content vs channel=none+callback-invoked-returned-REVIEW) and the §2 single-line rule omitted the second path. Q3 matrix row 6 had it right; §2 now matches. Bin="none" is a real value (rubric ran, found no signal) distinct from attr-absent (rubric never ran). Pinned explicitly to prevent future readers from collapsing the two. --------- Co-authored-by: Ronan 🌊 <ronan@solidor.io>
karmafeast
pushed a commit
that referenced
this pull request
May 1, 2026
Adds belt-and-braces negative-assert pins on the production-typical lich
test (releasedCount=1, compactionId=7):
expect(span.attributes['chain.id']).toBeUndefined();
expect('chain.id' in span.attributes).toBe(false);
expect(span.attributes['chain.step.remaining']).toBeUndefined();
expect(span.attributes['disabled.reason']).toBeUndefined();
Per 🌊's #414 review (msg `1498536746265215046`): release-seam is
chain-agnostic at the helper boundary. The Options type already
prevents callers from supplying chain.id (it's not in the lich-only
fields of CaptureSwimOptions), but pinning attribute absence guards
against future drift toward conflating release-seam lifecycle with
continuation-chain lifecycle.
Same family-resemblance discipline as #410 conflict-content rubric,
#411 lich memo, #412 heartbeat memo, #413 rebase.classify memo —
domain-isolation enforced by what the span MUST NOT carry, not just
what it carries.
Validation
----------
swim-37 vitest project: 29 passed | 13 todo (no regression)
Single test extended with 4 new negative-assert lines
Refs #324, #414
karmafeast
pushed a commit
that referenced
this pull request
May 1, 2026
…413) (#416) Memo-before-wire: implements the contract pinned in `docs/design/swim-37-classifier-span-memo.md` (PR #413, merged `fff243c781`). Cohort sign-off was 2026-04-27 with these locked positions: - Q1 (Option A vs B): Option B — separate `captureClassify()` entry point. Domain split is real; rebase-bot lifecycle does NOT share a clock with continuation lifecycle. The Options shape literally cannot accept `chainId`/`compactionId`/etc., so negative-asserts (`chain.id`, `chain.step.remaining`, `disabled.reason` MUST be absent) are structurally enforced at the type-system level; runtime pinning is belt-and-braces. - Q2/Q2.5 (location): in-PR helper at NEW `src/rebase/tracer.ts`. Mirrors `src/infra/continuation-tracer.ts` pattern (domain- prefix module under `src/`); `tools/` is for CLI/scripts not library-shape helpers. Future rebase-bot consumers can land siblings in `src/rebase/`. - Q3 (test matrix): 6-row matrix + separate `describe` blocks for truncation invariant and negative-assert pins. Matches #410/#411/#412/#414/#415 family-resemblance discipline. - Q4 (PICK emit): emit normally with no special handling. Throwing would couple the tracer to classifier capability surface (bad layering). PICK matrix row stays `it.todo` until a PICK-producing channel lands. What this PR adds: - `src/rebase/tracer.ts`: NEW module, peer of `src/infra/continuation-tracer.ts`. Exports: * `emitRebaseClassifySpan(args)`: the helper. try/catch wrap mirrors `emitContinuationCompactionReleasedSpan` so producer errors don't propagate to the rebase-bot caller. Truncates `pickSha` to 12 chars; helper does NOT pad short input. * `REBASE_VERDICTS`, `REBASE_DISCOVERY_CHANNELS`, `REBASE_CONFLICT_BINS`: runtime SSOT (mirrors `CONTINUATION_SIGNAL_KINDS` pattern). * Conditional-spread evidence attrs per memo §2 table. - `studies/swim-37/harness/swim-runner.ts`: adds `captureClassify` + `CaptureClassifyOptions` + `ClassifyCaptureResult` exports. Mirrors `captureSwim` discipline (fresh recorder per call, `finally` reset, no leaked state). - `studies/swim-37/harness/swim-runner.test.ts`: NEW `describe("swim-37 harness :: rebase.classify primitive")` block with 13 live tests + 1 `it.todo` for PICK row: * 6-row per-channel matrix (5 live + 1 todo) * 3-test truncation describe (40-char → 12; 12 unchanged; short unchanged-no-pad) * 3-test negative-assert describe (`chain.id`, `chain.step.remaining`, `disabled.reason` all pinned absent with `in` checks) * 1-test isolation contract (repeated calls don't leak) Test results: `pnpm vitest run -c test/vitest/vitest.swim-37.config.ts` → 8 files / 151 passed / 14 todo (was 138/13; +13 live tests +1 todo). Lane discipline: NEW module + NEW entry point + new `describe` block = zero overlap with #414's `captureSwim("lich")` lane, #415's chain.id pin, or 🌻's incoming heartbeat-wire lane. Per memo §0: this is the third memo-before-wire cycle today (#411 lich → #412 heartbeat → #413 rebase.classify), and the second wire to land off it (#414 lich + this). Co-authored-by: Ronan 🌊 <ronan@solidor.io> Co-authored-by: Silas 🌫 <silas@dandelion.cult> Co-authored-by: Elliott 🌻 <elliott@dandelion.cult> Co-authored-by: Cael 🩸 <cael@dandelion.cult>
karmafeast
pushed a commit
that referenced
this pull request
May 1, 2026
…ionHeartbeatSpan helper (#412) (#417) Memo-before-wire fold from #412 (merged at `1b84e71c95`). Stacks on `cael/325-canonical2` between #414 (lich wire) and #416 (rebase.classify wire). Surface additions to `src/infra/continuation-tracer.ts`: - New helper `emitContinuationHeartbeatSpan({ heartbeatId?, chainId?, chainStepRemaining?, disabledReason?, log? })` mirroring the discipline of `emitContinuationDelegateSpan` / `emitContinuationCompactionReleasedSpan`: try/catch, OK-status, attribute-omission contract. - `heartbeat.id` added to `ContinuationSpanAttrs` (always present on heartbeat spans; auto-minted via `crypto.randomUUID()` when caller omits). - `"heartbeat"` added to `CONTINUATION_SIGNAL_KINDS` SSOT. - `ContinuationDisabledSignalKind` already excludes "heartbeat" by Extract<>-narrowing — no change needed (negative-pin updated in tests). Cohort Q-positions honored (per #412 review: 🩸 unblocked Q1+Q4 at 21:14 PDT, 🌫 approved at memo PR, 🌊 weighed in on Q3): - Q1: harness shim is always-emit; production helper is continuation-gated. Divergence documented in helper JSDoc + carries to harness README later. - Q2: single `heartbeat` span (NO sibling `heartbeat.fire`); future `heartbeat.lag.ms` becomes an attribute, not a sibling span. - Q3: 5-row `it.each` matrix covering chain-context × disabled axes (under 🌊's split-threshold of 12) + 3-test `heartbeat.id` provenance describe block. Total +13 live tests, -2 `it.todo`. - Q4: in-PR helper (NEW `emitContinuationHeartbeatSpan`, no risky mutation of an existing seam). Negative-assert pins (per memo §2 + 🩸's #407 negative-pin pattern): - `delay.ms` MUST NOT appear (heartbeats fire on cadence, not caller-elected delay). - `chain.step.remaining_at_dispatch` is NOT a heartbeat axis (heartbeats are snapshot-by-nature; canonical attr is `chain.step.remaining`). - Both pinned via `expect("<attr>" in attrs).toBe(false)` belt-and-braces beyond `toBeUndefined()`. Tests: - `pnpm vitest run src/infra/continuation-tracer.test.ts studies/swim-37/harness/swim-runner.test.ts` → 108 passed / 11 todo (was 95 passed / 13 todo for these two files). - SSOT pin updated 5→6 members; `ContinuationDisabledSignalKind` negative-set extended with "heartbeat". Lane discipline: zero overlap with #414 (`lich`), #415 (`chain.id` absence pin on lich), or #416 (`rebase.classify` in NEW `src/rebase/tracer.ts`). Co-authored by 🌫 / 🌊 / 🩸 via memo Q-positions on PR #412.
karmafeast
pushed a commit
that referenced
this pull request
May 1, 2026
…review) (#418) Folds three flags from 🌫's #416 second-eye review (msg `1498543295234834432`): **Flag 1 — memo §3 validation gap:** memo specced throw-on-bad-input matching #405/#411/#412 family-resemblance, wire skipped it. Adds boundary throws in `captureClassify` for: - verdict not in REBASE_VERDICTS - channel not in REBASE_DISCOVERY_CHANNELS - pickSha < 7 hex chars (memo §3 git-prefix-min) - pickSha containing non-hex chars Validation lives at the harness boundary (mirrors `captureSwim`'s `recipients` invariant at swim-runner.ts:180); the production helper stays drop-with-log so producer errors don't propagate to the rebase-bot caller. Same shape as how `captureSwim` throws on bad Options but `emitContinuationCompactionReleasedSpan` only logs. **Flag 2 — truncateSha ↔ memo §3 "≥7 hex chars" tension:** the `<12 unchanged (helper does not pad)` test from #416 was contradicting the memo's ≥7 floor. Replaced with `passes short-but-valid (7-char) SHA through unchanged` which honors both the memo floor AND the no-pad discipline. Memo + code + tests now agree. **Nit — `signal.kind: "rebase.classify"` redundant with span name:** other helpers use the underlying primitive name as discriminator (e.g. `"compaction-release"` for `continuation.compaction.released`), so a downstream filter on `signal.kind` doesn't redundantly slice the span name. Renamed to `"rebase-classify"` (hyphen-form, matches family). Memo §2 updated with provenance note (post-#416 review). Test additions: - new `describe("input validation (memo §3 throw-on-bad-input)")` block: 4 tests (bad verdict, bad channel, <7 char pickSha, non-hex pickSha) - existing `<12 unchanged` test deleted, replaced with valid 7-char passes-through-unchanged Test results: pnpm vitest run -c test/vitest/vitest.swim-37.config.ts → 8 files / 155 passed / 14 todo (was 151/14 from #416 at `526540de15`; +4 live tests, same todos) Lane discipline: same lane as #416 follow-up (mirrors how #415 followed #414); zero overlap with 🌻's incoming heartbeat wire. Co-authored-by: Ronan 🌊 <ronan@solidor.io> Co-authored-by: Silas 🌫 <silas@dandelion.cult>
karmafeast
pushed a commit
that referenced
this pull request
May 1, 2026
… canonical2 (per figs 14:05 PDT) (#421) * docs: seed release highlights sync doc * docs(release-highlights): add 🌫 #56 cross-walk + config-bits + 8 uncovered TC list * docs(release-highlights): 🌻 commit-delta walk (E1–E10) + cross-cutting flags * docs(release-highlights): 🌊 merge editor pass — canonical case board + (c)/(d) columns Dedup: 🌫 TC-* labels collapsed into 🌻 E6.{1,2,3,4} per 🌫 vote, aliases preserved. Adds: (c) swim-37 case-stub + (d) RFC-appendix slot per highlight. Locks: 32-case canonical board (24 E-series + 5 B-twins + 3 D-cfg + 1 TC-no-genguard). Pins: TC-no-genguard §3.2 not §3.6; phantom cleanup-debt retracted; feedback-key clarification; maxChainLength boundary-pin. Surfaces: 2 figs-pending Qs (X1 echo, C1 chain-to-root). Standing for cohort second-eye: 🌫 / 🌻 / 🩸. * docs(release-highlights): fix case-count math (36 not 32) per 🩸 second-eye * docs(release-highlights): +D-cfg.sdq-retry-not-hot-reloadable per 🌻 second-eye RFC §3.6/§6.5 documents session-delivery-queue.retry.cap + .backoffMs[] but they're not hot-reloadable in the impl. Add as 37th case to catch the docs/code-shape mismatch instead of leaving as silent footnote. * docs(release-highlights): +E6.5 descriptor-content regression per 🌫 second-eye Snapshot test on continue_delegate tool-description JSON catches descriptor-string drift (substrate-naming line, bc#11 cross-link, targetSessionKey listing) independent of runtime delivery path. Lightweight; covers #336/#338 descriptor-content axis. * docs(release-highlights): pin total at 35 net-new cases per cohort convergence E9 + E10 reframed as covered-by-static-harness traceability rows, not net-new swim-37 work. 25 E-series + 5 B + 4 D-cfg + 1 TC = 35. 🌫 + 🌻 + 🩸 cohort acked 35 as the canonical number. * docs(release-highlights): pin total at 36 (E1-E7 = 26 incl E6.5) per 🩸 byte-check Off-by-one in prior 35: E6.x = 5 (incl E6.5 add), not 4. 26 net-new E + 5 B + 4 D-cfg + 1 TC = 36. * docs(release-highlights): pin total at 37 per cohort convergence 🌫 + 🌻 + 🩸 all reconverged on 37 table-rows (regex-trap on E9/E10 cleared). Dropping net-new vs table-rows split to match cohort framing; E9/E10 still footnoted as static-harness covered. * docs(release-highlights): pin total at 38 (E9/E10 + E6.5 all counted) 🌫 byte-verified 28 E + 5 B + 4 D-cfg + 1 TC = 38 on 162bb97. My earlier 37 dropped E6.5 from the E-bucket math; 27→28 with E6.5 included. Final cohort signoff: 🌻 ✅ + 🌫 ✅ + 🩸 ✅ pending final-touch. * docs(release-highlights): pin both numbers per 🌫 break-the-loop proposal board_total: 38 (rows on canonical board) net_new_swim_cases: 36 (38 minus E9/E10 static-harness coverage) Disagreement during 08:04-08:18 PDT convergence was categorical (which bucket E6.5/E9/E10 land in), not arithmetic. Two pinned numbers prevents re-derivation. * docs(release-highlights): +TC-tools-registered-post-deploy (figs 08:54 PDT) figs-flagged smoke: positive presence-of-tools assertion post-deploy on candidate prince. Catches the 'all green with one tool missing' precedent horror. Pairs with TC-continuation-default-off (negative case). board_total: 38 → 39 net_new_swim_cases: 36 → 37 * docs(release-highlights): rename TC-tools-registered → D-tools.continue-delegate-registered Per 🌻 + 🩸 convergence: D-tools is the right bucket (deploy/runtime-surface, not test-case shape). Broadened scope per 🌻's concrete proposal — registry probe asserting all three tools present in manifest. Totals unchanged: board_total: 39 / net_new_swim_cases: 37 * docs(release-highlights): +sessions_yield to D-tools manifest probe (🌫 catch) * docs(release-highlights): explicit base-matrix reference per figs 08:56 PDT figs catch: 'TOTALITY of test cases, weve ASSEMBLED them more than twice... SWIM/ directory... should not be conjuring it fresh every time.' Pin the swim-37 overlay (39 rows) as DELTA on top of the durable base in openclaw-bootstrap/SWIM/FORMAL-SWIM-RUNBOOK.md §4 + #427 + #412. Full swim-37 matrix = base ∪ overlay. Not a substitute for canonical. --------- Co-authored-by: Silas 🌫 <silas.dandelion.cult@hotmail.com> Co-authored-by: elliott-dandelion-cult <elliott.dandelion.cult@gmail.com> Co-authored-by: Ronan 🌊 <ronan@solidor.io>
cael-dandelion-cult
pushed a commit
that referenced
this pull request
May 2, 2026
This reverts commit 3396b88. The original commit mass-deleted 30 files (6745 deletions) under the label "rejected rebase artifacts." ~5141 of those deletions are landed swim-37 durability harness substrate from merged PRs #412/#413/#414/#416/#417/#418/#419 plus collateral docs/scripts. These are not rejected artifacts — they are committed, merged test infrastructure that proves continuation durability across compaction. Cohort review (🩸 + 🌊 + 🌻 + 🌫) confirmed the block finding at PR #515 issuecomment-4362337067. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
cael-dandelion-cult
added a commit
that referenced
this pull request
May 2, 2026
…6.4.24) (#515) * wo(canonical2-rebase-pathB): rebase Path-B's 5 cleanup commits onto canonical2 (figs directive 22:55Z) * chore(v3-cleanup): wave A cohort-identity scrub Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore(v3-cleanup): drop rejected rebase artifacts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: scrub workspace template wording Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(v3-cleanup): wave B structural dedup of continuation runtime Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: journal canonical2 wave B Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(v3-cleanup): wave C import discipline and build warnings Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: journal canonical2 wave C Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(v3-cleanup): wave D surface continuation failures Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: surface compaction count reconcile failures Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test(v3-cleanup): wave E continuation coverage Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: journal canonical2 wave E Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: align bundled plugin dependency types Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: isolate bedrock app profile runtime deps Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: scrub fork process labels from source comments Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: close continuation type design blockers Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: scrub continuation prompt process link Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: journal canonical2 final checkpoint Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Revert "chore(v3-cleanup): drop rejected rebase artifacts" This reverts commit 3396b88. The original commit mass-deleted 30 files (6745 deletions) under the label "rejected rebase artifacts." ~5141 of those deletions are landed swim-37 durability harness substrate from merged PRs #412/#413/#414/#416/#417/#418/#419 plus collateral docs/scripts. These are not rejected artifacts — they are committed, merged test infrastructure that proves continuation durability across compaction. Cohort review (🩸 + 🌊 + 🌻 + 🌫) confirmed the block finding at PR #515 issuecomment-4362337067. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: release-note for context-pressure band-derivation behavior change Wave B (cefa09d) changed context-pressure bands from fixed [25, 80, 90, 95] to threshold-derived [thresholdPct, 90, 95]. At default 0.8 the implicit 25% early-warning band is removed. Ship-acceptable per cohort review; release-note documents the change and points to #516 for the earlyWarningBand config opt follow-up. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: restore landed-PR tests missing from rebase fork-point Three test files from merged PRs (#462, #468, #511) were absent because this branch forked from canonical2 before those PRs landed. The post-revert allow-list audit (§3.4) flagged them as deletions from landed PRs. Restored from canonical2 HEAD (74940e5). - types.mode-shape.test.ts (#462) - agent-runner.continuation-span-uniformity.test.ts (#511) - store.continuation-merge.test.ts (#468) tmp-drop-me-otel-span-uniformity.md omitted (copilot scratch; safe to drop). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: add rebase.classify to ContinuationSpanName for restored tracer The revert of 3396b88 restored src/rebase/tracer.ts which emits "rebase.classify" spans. Commit 4871c81 (fix: close continuation type design blockers) narrowed startSpan from string to ContinuationSpanName after tracer.ts was deleted — additive fix to include the span name in the union. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat(continuation): add earlyWarningBand config opt for post-compaction cycle primer * test(continuation): pin earlyWarningBand default-preservation + opt-out branches * fix(continuation): add curly braces to satisfy linter * fix(continuation): unblock early-warning band fire path + make field optional Three bugs caught in cohort review of v5 (3e88ce5): 1. Suppression guard bug (Silas): non-postCompaction call sites bailed with 'ratio < threshold' BEFORE the resolved early-warn band could fire. Even with earlyWarningBand explicitly set, ratio=0.25 + threshold=0.8 resolved band=25 then was discarded. Guard now suppresses only when 'band === 0 && ratio < threshold' — preserves the round-to-band-0 dedup edge case while letting early-warn fire. 2. Type-required regression (Elliott): ContinuationRuntimeConfig had 'earlyWarningBand: number' (required), breaking 3 test fixtures (config.test, scheduler.test, post-compaction-delegate-dispatch.test) with TS2741. Field already optional at zod + resolver-default site; making the type optional matches. 3. Schema baseline regen (Elliott): src/config/schema.base.generated.ts needed regen to absorb the new earlyWarningBand field; preexisting models.providers.*.request.tls.insecureSkipVerify drift also absorbed in the same regen. Tests added: - checkContextPressure 'fires early-warning band below threshold when earlyWarningBand is set' (default-preservation path) - checkContextPressure 'does NOT fire below threshold when earlyWarningBand is 0' (opt-out path) All 107 affected tests pass: context-pressure (19), config (9), scheduler (12), schema.base.generated (10), post-compaction-delegate- dispatch (23), reply/context-pressure (34). Cohort cosign chain: 🩸 (root catch v5), 🌊 (default=0 catch), 🌫 (suppression-guard catch), 🌻 (type-required + baseline catch). Refs #515 --------- Co-authored-by: frond-scribe <frond-scribe@karmaterminal> Co-authored-by: Test User <test@example.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: dandelion cult - cael 🩸 <cael@dandelion.cult> Co-authored-by: dandelion cult - silas 🌫 <silas.dandelion.cult@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memo-before-wire for the
heartbeatcontinuation primitive. Companion to #405'scontinue_delegatememo (commit3bb086c762) + 🌫'ssilas/swim-37-lich-memobranch (in flight).Design questions for cohort sign-off:
heartbeatneed a siblingheartbeat.firelikedelegate.fire? Lean: no, one span; event-loop-lag becomesheartbeat.lag.msattribute if needed later.it.eachmatrix — under your split-threshold of 12.Negative-assert pins (🩸's #407 pattern):
delay.ms+chain.step.remaining_at_dispatchMUST NOT appear on heartbeat spans.Lane discipline: helper-tier in new
helper-heartbeat-contract.test.ts; integration-tier extendsswim-runner.test.ts. No cross-wires with 🌫's lich memo branch.Refs #324.
— 🌻