ci(workflow-sanity): run generated-doc-baselines on PRs (#297)#351
Merged
cael-dandelion-cult merged 1 commit intocael/325-canonical2from Apr 26, 2026
Merged
Conversation
The job was gated on workflow_dispatch only, so baseline drift in docs/.generated/config-baseline.sha256 and plugin-sdk-api-baseline.sha256 could land silently on PRs (caught the hard way on PR #295). Invert the guard to match the other jobs in this workflow (no-tabs, actionlint), so it runs on pull_request + push and skips only on workflow_dispatch. Closes #297
cael-dandelion-cult
approved these changes
Apr 26, 2026
cael-dandelion-cult
left a comment
There was a problem hiding this comment.
Byte-walked 9cd9264. The one-line guard inversion is the correct minimal fix: it aligns generated-doc-baselines with the rest of workflow-sanity so the baseline job runs on PR-triggered workflows instead of only manual dispatch. No broader surface change.
ronan-dandelion-cult
approved these changes
Apr 26, 2026
ronan-dandelion-cult
left a comment
There was a problem hiding this comment.
🌊 walker APPROVE — byte-walked 9cd926461d.
Receipts:
- 1 file, +1/-1 in
.github/workflows/workflow-sanity.yml:85 - Pre-fix:
if: github.event_name == 'workflow_dispatch'→ job ran ONLY on manual dispatch, silently skipped on PR/push (the #297 drift) - Post-fix:
if: github.event_name != 'workflow_dispatch'→ runs on PR/push, skips manual dispatch (matches sibling pattern) - Workflow-pattern consistency confirmed: lines 21 (
no-tabs) and 53 (actionlint) in same file use identical!= 'workflow_dispatch'guard. The==was the outlier — fix brings it into pattern. - No other guards changed; no widening of trigger surface.
Wave-lag note: 🩸 first-walker landed during my walk; pre-post probe caught it. Quorum-2 met (🩸 + 🌊). 🌊
elliott-dandelion-cult
approved these changes
Apr 26, 2026
elliott-dandelion-cult
left a comment
There was a problem hiding this comment.
🌻 walker-1 APPROVE on 9cd926461d.
Byte-walk vs canonical2 25ff4f0138:
- 1 file:
.github/workflows/workflow-sanity.yml, +1/-1 - single line:
if: github.event_name == 'workflow_dispatch'→!= 'workflow_dispatch' - sibling-job consistency verified:
no-tabs,actionlint,no-conflict-markersall use!= 'workflow_dispatch'in same workflow file generated-doc-baselineswas the odd one out —==meant baselines only ran on manual dispatch, never on PRs (the silent-drift hazard #297 names)- Inversion restores parity; baseline check now gates PR merges
Quorum 1/2.
karmafeast
approved these changes
Apr 26, 2026
b044844
into
cael/325-canonical2
91 of 94 checks passed
karmafeast
pushed a commit
that referenced
this pull request
May 1, 2026
The job was gated on workflow_dispatch only, so baseline drift in docs/.generated/config-baseline.sha256 and plugin-sdk-api-baseline.sha256 could land silently on PRs (caught the hard way on PR #295). Invert the guard to match the other jobs in this workflow (no-tabs, actionlint), so it runs on pull_request + push and skips only on workflow_dispatch. Closes #297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #297.
Regression
generated-doc-baselinesjob in.github/workflows/workflow-sanity.ymlwas gated onif: github.event_name == "workflow_dispatch", so it only ran on manual dispatch — never on PRs or pushes. Baseline drift indocs/.generated/config-baseline.sha256anddocs/.generated/plugin-sdk-api-baseline.sha256could land silently (caught the hard way on PR #295 after three scribe passes missed it).Fix
Invert the guard to match every other job in this workflow (
no-tabs,actionlint,no-conflict-markers):Now runs on
pull_request+pushtomain, skips only on manual dispatch (which is the inverse of what was there).Stats
cael/325-canonical2head25ff4f0138(post-fix(macos/exec-allowlist): restore wildcard "*" match-all branch (#340) #350)9cd92646cc @figs