Skip to content

op-interop-filter: Address PR review comments, add Rewind stub, and fix JWT auth#13

Merged
karlfloersch merged 2 commits intointerop-filter-basefrom
feat/interop-filter-skeleton
Dec 2, 2025
Merged

op-interop-filter: Address PR review comments, add Rewind stub, and fix JWT auth#13
karlfloersch merged 2 commits intointerop-filter-basefrom
feat/interop-filter-skeleton

Conversation

@karlfloersch
Copy link
Copy Markdown
Owner

@karlfloersch karlfloersch commented Dec 1, 2025

No description provided.

@karlfloersch karlfloersch force-pushed the interop-filter-base branch 2 times, most recently from aee98bd to c0a7ee2 Compare December 1, 2025 18:39
- Remove comment from .gitignore
- Remove 'op-geth' from app description to be client-agnostic
- Simplify CheckAccessList error handling to match op-supervisor
- Update SetFailsafeEnabled to indicate pending implementation
- Add JWT secret flag and wire up authentication for admin RPC

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@opsuperchain opsuperchain force-pushed the feat/interop-filter-skeleton branch from 6cc4e24 to c2be9c5 Compare December 2, 2025 16:41
@opsuperchain opsuperchain changed the title fix(op-interop-filter): use procName for metrics namespace op-interop-filter: Address PR review comments Dec 2, 2025
@karlfloersch karlfloersch changed the title op-interop-filter: Address PR review comments op-interop-filter: Updates... Dec 2, 2025
@karlfloersch karlfloersch changed the title op-interop-filter: Updates... op-interop-filter: Skeleton updates... Dec 2, 2025
Adds Rewind method to AdminFrontend as a stub for future implementation.
This will allow operators to recover from reorg-induced stuck states
via manual intervention.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@karlfloersch karlfloersch changed the title op-interop-filter: Skeleton updates... op-interop-filter: Address PR review comments, add Rewind stub, and fix JWT auth Dec 2, 2025
@karlfloersch karlfloersch merged commit bf24caa into interop-filter-base Dec 2, 2025
opsuperchain pushed a commit that referenced this pull request Mar 8, 2026
…imism#19281)

* fix(contracts): address audit findings #14, #6, #8, #13, #19

- #14: Reuse existing DelayedWETH from SystemConfig instead of deploying
  a new one in the Migrator, preventing divergence with future upgrades
- #6: Document that hardcoded game type lists in OPCMv2 and Migrator are
  intentional and must be kept in sync when new types are added
- #8: Document that migrate() does not enforce SuperchainConfig version floor
- #13: Document why migration game config validation is deliberately minimal
- #19: Document theoretical risk in AnchorStateRegistry.isGameRegistered
  when ASR proxy is replaced non-atomically

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(contracts): add cross-reference comment to GameTypes library

Add a notice to the GameTypes library reminding developers to update
the hardcoded game type lists in OPContractsManagerMigrator and
OPContractsManagerV2's _assertValidFullConfig when adding new types.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(contracts): bump OPContractsManagerV2 version for rebase

Bump OPContractsManagerV2 from 7.0.9 to 7.0.10 to account for the
comment-only source change (cross-reference note added in prior commit)
that affects the bytecode metadata hash.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(contracts): bump OPContractsManagerV2 version to 7.0.11 for semver-diff CI fix

* fix(contracts): apply forge fmt and bump versions for formatting changes

forge fmt changed OPContractsManager, FaultDisputeGame, SuperFaultDisputeGame,
and several other files. Bump patch versions for the contracts with hash changes,
and regenerate semver-lock and snapshots.

- OPContractsManager: 6.0.3 -> 6.0.4
- FaultDisputeGame: 2.4.0 -> 2.4.1
- SuperFaultDisputeGame: 0.7.0 -> 0.7.1

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: smartcontracts <smartcontracts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant