Skip to content

feat(op-interop-filter): add sysgo e2e tests [4/4]#11

Open
opsuperchain wants to merge 2 commits intofeat/interop-filter-sysgo-presetfrom
feat/interop-filter-sysgo-tests
Open

feat(op-interop-filter): add sysgo e2e tests [4/4]#11
opsuperchain wants to merge 2 commits intofeat/interop-filter-sysgo-presetfrom
feat/interop-filter-sysgo-tests

Conversation

@opsuperchain
Copy link
Copy Markdown
Collaborator

@opsuperchain opsuperchain commented Nov 26, 2025

Summary

This is PR 4 of 4 for the op-interop-filter service.

This PR adds sysgo integration tests:

  • Startup test: Verifies interop filter can be hydrated into the system
  • Failsafe test: Verifies failsafe is initially disabled
  • Ready state test: Verifies filter becomes ready after backfill
  • Matcher test: Verifies FirstInteropFilter matcher works

Stack

This PR is part of a stacked PR series:

  • [1/4] Skeleton & flags
  • [2/4] Core logic and unit tests
  • [3/4] Sysgo integration and preset
  • [4/4] Sysgo e2e tests ← this PR

Test plan

  • go build ./op-devstack/sysgo/...
  • go test ./op-devstack/sysgo/... -run TestInteropFilter

🤖 Generated with Claude Code

@opsuperchain opsuperchain force-pushed the feat/interop-filter-sysgo-preset branch from 4863aa1 to e5cdf5b Compare November 27, 2025 00:52
@opsuperchain opsuperchain force-pushed the feat/interop-filter-sysgo-tests branch 2 times, most recently from b785d7a to 77e4f3b Compare November 27, 2025 00:55
@opsuperchain opsuperchain force-pushed the feat/interop-filter-sysgo-preset branch from e5cdf5b to bd3795e Compare November 27, 2025 06:25
@opsuperchain opsuperchain force-pushed the feat/interop-filter-sysgo-tests branch from 77e4f3b to 65783b6 Compare November 27, 2025 06:26
@opsuperchain opsuperchain force-pushed the feat/interop-filter-sysgo-preset branch from bd3795e to 99ed03d Compare December 1, 2025 15:01
opsuperchain and others added 2 commits December 1, 2025 15:01
This PR adds op-devstack/sysgo integration for op-interop-filter:

- `op-service/apis/interop_filter.go`: InteropFilter API interfaces
- `op-service/sources/interop_filter_client.go`: RPC client for interop filter
- `op-devstack/stack/interop_filter.go`: InteropFilterID and InteropFilter interface
- `op-devstack/shim/interop_filter.go`: Shim implementation
- `op-devstack/sysgo/interop_filter.go`: WithInteropFilter function
- `op-devstack/dsl/interop_filter.go`: DSL wrapper
- `op-devstack/presets/minimal_with_interop_filter.go`: Preset for tests
- Updated system interface to include InteropFilter methods
- Added FirstInteropFilter matcher

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This PR adds sysgo integration tests for op-interop-filter:

- Test interop filter startup and hydration
- Test failsafe initial state
- Test filter ready state after backfill
- Matcher infrastructure test

Note: The full e2e tests require the sysgo deployer infrastructure,
which currently has some ABI mismatch issues. Tests will pass once
those issues are resolved in the base branch.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@opsuperchain opsuperchain force-pushed the feat/interop-filter-sysgo-tests branch from 65783b6 to fc2a3ff Compare December 1, 2025 15:02
karlfloersch pushed a commit that referenced this pull request Mar 5, 2026
…thereum-optimism#19272)

* contracts: implement audit code fixes and add tests

Add onlyDelegateCall enforcement to upgradeSuperchain, upgrade, and
migrate functions (#17). Include msg.sender in deploy salt to prevent
cross-caller CREATE2 collisions (#17). Add duplicate instruction key
detection in upgrade validation (#9). Validate startingRespectedGameType
against enabled game configs (#10). Add code-existence check in
loadBytes (#18). Add setUp guard to VerifyOPCM.runSingle (#4). Remove
unused _findChar function (#5). Pass real AddressManager in migrator
proxy deploy args (#11). Add tests covering all audit fix behaviors.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* contracts: regenerate semver-lock.json for OPContractsManagerV2

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* contracts: bump OPContractsManagerV2 version to 7.0.10

Semver-diff requires a patch version bump when bytecode changes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant