Skip to content

chore(benchmark): improve the readability of benchmark stats#523

Merged
ijsong merged 1 commit intomainfrom
benchmark_more_readable_stats
Jul 28, 2023
Merged

chore(benchmark): improve the readability of benchmark stats#523
ijsong merged 1 commit intomainfrom
benchmark_more_readable_stats

Conversation

@ijsong
Copy link
Copy Markdown
Member

@ijsong ijsong commented Jul 11, 2023

What this PR does

Before:

___tgt__arpsR__arpsT_______abpsR_______abpsT__adurR__adurT__slpsR__slpsT_______sbpsR_______sbpsT__eelatR__eelatT
   1:123664.023244.1  92.44MiB/s   90.8MiB/s    4.0    4.0    0.0    0.0        0B/s        0B/s     0.0     0.0

Current:

target_____arps(now,tot)_________abps(now,tot)_adur(now,tot)_____slps(now,tot)_________sbps(now,tot)__eelat(now,tot)
   1:1  24.3k/s 23.38k/s 94.93MiB/s 91.32MiB/s  4.4ms  4.6ms      0/s      0/s       0B/s       0B/s   0.0ms   0.0ms

@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jul 11, 2023

@ijsong ijsong self-assigned this Jul 11, 2023
@ijsong ijsong force-pushed the benchmark_append_duration_resolution branch from 4d03559 to 448603f Compare July 12, 2023 09:20
@ijsong ijsong force-pushed the benchmark_more_readable_stats branch from 7622c73 to 8b9823f Compare July 12, 2023 09:20
Before:
```
___tgt__arpsR__arpsT_______abpsR_______abpsT__adurR__adurT__slpsR__slpsT_______sbpsR_______sbpsT__eelatR__eelatT
   1:123664.023244.1  92.44MiB/s   90.8MiB/s    4.0    4.0    0.0    0.0        0B/s        0B/s     0.0     0.0
```

Current:
```
target_____arps(now,tot)_________abps(now,tot)_adur(now,tot)_____slps(now,tot)_________sbps(now,tot)__eelat(now,tot)
   1:1  24.3k/s 23.38k/s 94.93MiB/s 91.32MiB/s  4.4ms  4.6ms      0/s      0/s       0B/s       0B/s   0.0ms   0.0ms
```
@ijsong ijsong force-pushed the benchmark_append_duration_resolution branch from 448603f to e3a091d Compare July 28, 2023 07:01
@ijsong ijsong force-pushed the benchmark_more_readable_stats branch from 8b9823f to 7d94665 Compare July 28, 2023 07:02
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 28, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.75%. Comparing base (e3a091d) to head (7d94665).
⚠️ Report is 930 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage   61.74%   61.75%           
=======================================
  Files         137      137           
  Lines       18664    18667    +3     
=======================================
+ Hits        11525    11527    +2     
  Misses       6565     6565           
- Partials      574      575    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jul 28, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

Base automatically changed from benchmark_append_duration_resolution to main July 28, 2023 07:46
@ijsong ijsong merged commit d673761 into main Jul 28, 2023
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jul 28, 2023

@ijsong merged this pull request with Graphite.

@ijsong ijsong deleted the benchmark_more_readable_stats branch July 28, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants