Skip to content

Add eslint and prettier config#27

Merged
em3s merged 5 commits intokakao:mainfrom
csbiy:feat/add-eslint-prettier-config
Jan 14, 2026
Merged

Add eslint and prettier config#27
em3s merged 5 commits intokakao:mainfrom
csbiy:feat/add-eslint-prettier-config

Conversation

@csbiy
Copy link
Copy Markdown
Contributor

@csbiy csbiy commented Jan 10, 2026

Closes #24

Added ESLint and Prettier setup for the /website directory.

Changes

  • .prettierrc - basic formatting rules (semicolons, single quotes, etc)
  • eslint.config.js - flat config with typescript-eslint, uses globals package for node/browser env
  • package.json - added lint/format scripts and devDependencies

Scripts added

npm run lint        # check for issues
npm run lint:fix    # auto-fix what we can
npm run format      # format with prettier
npm run format:check # check formatting in CI

Tested locally, lint passes after fixing the globals issue (was getting "process is not defined" errors before adding the globals package).

csbiy added 4 commits January 10, 2026 17:33
@csbiy
feat(website): add ESLint and Prettier configuration
99a193e 
Add formatting and linting setup for the /website directory:
- .prettierrc with standard defaults
- eslint.config.js using flat config format
- Updated package.json with format/lint scripts

Fixes kakao#24
@csbiy
fix(website): add globals for Node.js and browser environments
9da3cb2
@csbiy
fix(website): add globals package dependency
2be1016
@csbiy
add comments to eslint config
f72c8b4
@csbiy csbiy requested a review from em3s as a code owner January 10, 2026 08:39
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 10, 2026
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 10, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added the enhancement New feature or request label Jan 10, 2026
@em3s
Copy link
Copy Markdown
Contributor

em3s commented Jan 12, 2026 •
edited
Loading

@csbiy Thanks for the PR — appreciate the quick contribution!

For future issues, we usually ask contributors to comment “I’d like to take this” before starting, to avoid duplicate work. No worries this time.

I’ll review the code and follow up with feedback.

👉 As a next step, please add a comment saying “I’d like to take this” on issue #24 so we can assign it to you.

We’ll also update the contributing guide to make this flow clearer.

@csbiy
Copy link
Copy Markdown
Contributor Author

csbiy commented Jan 14, 2026

@em3s , Thanks for the feedback! I'll keep that in mind for future contributions — will make sure to comment "I'd like to take this" before starting work.

I've just left a comment on issue #24. Looking forward to your code review!

@csbiy csbiy mentioned this pull request Jan 14, 2026
Closed
@em3s
Copy link
Copy Markdown
Contributor

em3s commented Jan 14, 2026

No worries at all, and thanks for being proactive! I’ll review the PR shortly. @csbiy

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 14, 2026
@em3s
Copy link
Copy Markdown
Contributor

em3s commented Jan 14, 2026 •
edited
Loading

Overall, this looks like a clean and solid baseline.
For reproducibility, I’ll add package-lock.json and then proceed with the merge.
We can build on top of this incrementally going forward.

A follow-up PR to apply this will be opened shortly.

Thanks for the contribution. @csbiy

@em3s em3s merged commit 6d3841b into kakao:main Jan 14, 2026
2 checks passed
This was referenced Jan 14, 2026
Merged
Closed
csbiy added a commit to csbiy/actionbase that referenced this pull request Jan 17, 2026
@csbiy
Add GitHub Actions CI for /website
7a55713 
- Run ESLint and Prettier on pull requests
- Trigger only when website files or workflow changes
- Use config from kakao#27

Closes kakao#47
@csbiy csbiy mentioned this pull request Jan 17, 2026
Merged
csbiy added a commit to csbiy/actionbase that referenced this pull request Jan 17, 2026
@csbiy
Add GitHub Actions CI for /website
090de79 
- Run ESLint and Prettier on pull requests
- Build website to verify it compiles successfully
- Trigger only when website files or workflow changes
- Use config from kakao#27

Closes kakao#47
csbiy added a commit to csbiy/actionbase that referenced this pull request Jan 17, 2026
@csbiy
Add GitHub Actions CI for /website
782893d 
- Run ESLint and Prettier on pull requests
- Build website to verify it compiles successfully
- Trigger only when website files or workflow changes
- Use config from kakao#27

Closes kakao#47
csbiy added a commit to csbiy/actionbase that referenced this pull request Jan 17, 2026
@csbiy
Add GitHub Actions CI for /website
0e4d5f7 
- Run ESLint and Prettier on pull requests
- Build website to verify it compiles successfully
- Trigger only when website files or workflow changes
- Use config from kakao#27

Closes kakao#47
@em3s em3s changed the title feat(website): add eslint and prettier config Add eslint and prettier config Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@em3s em3s em3s approved these changes

Assignees

@csbiy csbiy

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add basic formatting and linting to /website

3 participants

@csbiy @CLAassistant @em3s