Migrate ActionbaseQuery to v3 engine layer#218
Merged
Conversation
em3s
previously requested changes
Mar 22, 2026
Contributor
em3s
left a comment
There was a problem hiding this comment.
It should also rename v2 terms to v3 conventions – e.g. src -> source, tgt -> target in ActionbaeQuery Model.
…onbaseQuery Rename src -> source, tgt -> target, dir -> direction to align with v3 naming conventions per PR #218 review feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@em3s Also renamed service → database, label → table to align with v3 conventions. |
…eQuery Align ActionbaseQuery field names with v3 naming conventions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…d update test JSON to v3 terms Fix typo in test class name and update JSON fixtures to use v3 field names (database, table, source, target, direction). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move ActionbaseQuerySpec, ActionbaseQueryParserSpec, ActionbaseQueryExecutorPostProcess*Spec, and StepByStepLog from engine.query to engine.v3.query package. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Rename service/label/src/dir to database/table/source/direction in ActionbaseQuery.Item.Cache and update related test fixtures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ctionbaseQuery - Rename Item.cache flag to memoize to avoid collision with Cache type - Rename Cache.cacheName to cache for conciseness Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove redundant ActionbaseQueryController and NamedQueryResultV3. Update QueryController to delegate to V3QueryService instead of Graph directly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
….query Move query implementation classes out of v2 package to prepare for v3 native usage: - ActionbaseQuery, ActionbaseQueryExecutor, LabelProvider, Compat - Extract NamedQueryResult to separate file - Rename ActionbaseQueryCacheE2ETest to ActionbaseQueryE2ETest Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…mments - Fix processCount to use queryItem.direction instead of hardcoded Direction.OUT - Update TODO comment: cacheName → cache - Revert E2E test schema comments to v3 terms (source/target) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Vertex.Ref.field references DataFrame column names which are still v2 terms (src/tgt). Using "target" would cause runtime lookup failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
engine.query has V2 direct calls (see #221), will be addressed in follow-up PRs. |
1 task
eazyhozy
pushed a commit
that referenced
this pull request
Apr 1, 2026
Co-authored-by: Minseok Kim <mskim@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #217 (review), move the
/graph/v3/queryendpoint from the v2QueryControllerto the v3 layer.Integrate the ActionbaseQuery execution path into V3QueryService, following the existing v3 pattern (V3QueryService → Graph).
Changes
Checklist
./gradlew build)