Skip to content

Make metadata getAll fetch limit configurable#209

Merged
em3s merged 3 commits intomainfrom
feat/ddl-fetch-limit
Mar 1, 2026
Merged

Make metadata getAll fetch limit configurable#209
em3s merged 3 commits intomainfrom
feat/ddl-fetch-limit

Conversation

@em3s
Copy link
Copy Markdown
Contributor

@em3s em3s commented Mar 1, 2026 •
edited
Loading

Summary

  • The hardcoded fetch limit of 1000 in getAll() of the V2 DDL service is now configurable via the kc.graph.metadata-fetch-limit property
  • Default value remains 1000 to preserve existing behavior
  • The hardcoded fetch size in Graph.getOnlineMetadata() also uses the same setting

Changed Files

File Change
GraphConfig Added metadataFetchLimit field and Builder method
Graph Passes limit when constructing DDL services + getOnlineMetadata
*DdlService (5 files) Support for receiving limit parameter
GraphProperties Spring property binding
GraphConfiguration Binds property to GraphConfig

Usage

kc:
  graph:
    metadata-fetch-limit: 2000  # default: 1000

Tests

  • ./gradlew build passes
  • DDL-related tests (DdlServiceSpec, ServiceSpec, StorageSpec, LabelSpec) pass

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Mar 1, 2026
@em3s em3s changed the title Make DDL getAll fetch limit configurable Make metadata getAll fetch limit configurable Mar 1, 2026
@em3s em3s merged commit 222b005 into main Mar 1, 2026
7 checks passed
em3s added a commit that referenced this pull request Mar 1, 2026
@em3s
Make metadata getAll fetch limit configurable (#209)
4205744
@em3s em3s deleted the feat/ddl-fetch-limit branch March 1, 2026 12:58
em3s added a commit that referenced this pull request Mar 3, 2026
@em3s @claude
fix(engine): restore metadataFetchLimit in getOnlineMetadata lost dur…
f77e714 
…ing merge

The merge ec86cd0 reverted #209 change that replaced the hardcoded
sufficientFetchSize=1000 with the configurable metadataFetchLimit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@em3s