Skip to content

Conversation

@onematchfox
Copy link
Contributor

@onematchfox onematchfox commented Aug 15, 2025

Missed in #683.

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 15, 2025 08:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a naming inconsistency in the MCP server controller by updating the controller name to match the managed object type.

  • Updates the controller name from "toolserver" to "mcpserver" to align with the MCPServer resource type

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@onematchfox onematchfox marked this pull request as draft August 15, 2025 10:47
@onematchfox
Copy link
Contributor Author

onematchfox commented Aug 15, 2025

Not so simple... mcpserver is already used by KMCP. Big code smell here 🐟 Will try to revisit at a later stage

@onematchfox onematchfox deleted the fix-controller-name branch September 5, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant