fix the A2A types, cleanup bunch of stuff #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the A2A (Agent-to-Agent) types by consolidating type definitions from multiple files into a centralized location and updating the message handling system to work with the A2A SDK.
- Consolidates all type definitions from
datamodel.tsandlib/types.tsinto a singletypes/index.tsfile - Updates all imports across the codebase to use the centralized types
- Removes legacy message handling utilities and replaces them with A2A SDK compatible implementations
- Updates session handling to work with Task objects instead of legacy message structures
Reviewed Changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/src/types/index.ts | New centralized type definitions file consolidating all types |
| ui/src/types/datamodel.ts | Deleted - types moved to central location |
| ui/src/lib/types.ts | Deleted - types moved to central location |
| ui/src/lib/utils.ts | Removed legacy message utilities, kept A2A utilities |
| ui/src/lib/messageHandlers.ts | Major refactor to work with A2A SDK Message objects |
| ui/src/components/chat/*.tsx | Updated to work with A2A Message objects instead of legacy types |
| ui/src/app/actions/sessions.ts | Updated to handle Task objects instead of messages |
| Various other files | Updated imports to use centralized types |
Comments suppressed due to low confidence (3)
ui/src/types/index.ts:69
- Missing semicolon after
azureEndpoint: stringon line 71. The line should end with a semicolon for consistency with other properties.
export interface AzureOpenAIConfigPayload {
ui/src/lib/messageHandlers.ts:132
- Using
(part as any).texton line 133 bypasses TypeScript's type safety. Consider properly typing the part or using a type guard to check if it's a TextPart before accessing the text property.
content: string,
ui/src/components/chat/StatusDisplay.tsx:19
- Missing semicolon after the closing parenthesis. The line should end with a semicolon for consistency.
)
* Update README.md Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> --------- Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
bef183c to
96fd6eb
Compare
EItanya
approved these changes
Aug 1, 2025
This was referenced Aug 5, 2025
UriZafrir
pushed a commit
to UriZafrir/kagent
that referenced
this pull request
Aug 7, 2025
* Update README.md (kagent-dev#661) * Update README.md Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> --------- Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * fix the A2A types, cleanup bunch of stuff Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> --------- Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com>
UriZafrir
pushed a commit
to UriZafrir/kagent
that referenced
this pull request
Aug 7, 2025
* Update README.md (kagent-dev#661) * Update README.md Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> --------- Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * fix the A2A types, cleanup bunch of stuff Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> --------- Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes up the A2A sessions, removing unused types and the datamodel.ts file (remaining types moved to /types).