add Kube controller #12

ilackarms · 2025-01-28T17:53:23Z

initializes the kube controller component of kagent

yuval-k · 2025-01-28T18:28:32Z

controller/api/v1alpha1/autogenteam_types.go

+	// ONEOF: maxMessageTermination, textMentionTermination, orTermination
+	MaxMessageTermination  *MaxMessageTermination  `json:"maxMessageTermination,omitempty"`
+	TextMentionTermination *TextMentionTermination `json:"textMentionTermination,omitempty"`
+	OrTermination          *OrTermination          `json:"orTermination,omitempty"`


including OrTermination here creates a recursive datastructure. is that the intent?

yuval-k · 2025-01-28T18:29:53Z

controller/api/v1alpha1/autogenmodelconfig_types.go

+// AutogenModelConfigSpec defines the desired state of AutogenModelConfig.
+type AutogenModelConfigSpec struct {
+	Model           string `json:"model"`
+	APIKeySecret    string `json:"apiKeySecret"`


should this be a ref to a secret?

npolshakova · 2025-01-29T15:23:27Z

controller/api/v1alpha1/autogenteam_types.go

+	ModelConfig    string `json:"modelConfig"`
+}
+
+type TerminationCondition struct {


Maybe "TerminationType" and add validation:

// +kubebuilder:validation:XValidation:message="There must one termination type set",rule="1 == (self.maxMessageTermination != null?1:0) + (self.textMentionTermination != null?1:0) + (self.orTermination != null?1:0)"

npolshakova · 2025-01-29T15:27:45Z

controller/api/v1alpha1/autogentool_types.go

+
+// AutogenToolSpec defines the desired state of AutogenTool.
+type AutogenToolSpec struct {
+	Description string `json:"description,omitempty"`


Are there additional things we need to define on the tool? https://github.com/microsoft/autogen/blob/2f1684b698e83418d47f54309b426ddfd022f3ee/python/packages/autogen-core/src/autogen_core/tools/_base.py#L77

tool is a placeholder for now; we can fill it out once we have some examples of user-created tools to support

npolshakova · 2025-01-29T15:28:27Z

controller/api/v1alpha1/autogentool_types.go

+	metav1.ObjectMeta `json:"metadata,omitempty"`
+
+	Spec   AutogenToolSpec   `json:"spec,omitempty"`
+	Status AutogenToolStatus `json:"status,omitempty"`


What would a tool status contain? (Which agents are using it?)

npolshakova · 2025-01-29T15:29:38Z

controller/api/v1alpha1/autogenagent_types.go

+	Name          string   `json:"name,omitempty"`
+	Description   string   `json:"description,omitempty"`
+	SystemMessage string   `json:"systemMessage,omitempty"`
+	Tools         []string `json:"tools,omitempty"`


This would match the built-in tools name? (ie. k8s.apply_manifest, istio.generate_resource, etc.)

yes or it could also refer to the name of a user-provided tool (defined as a crd)

EItanya

Any reason we're not starting our controllers off with krt? It will handle a lot of the boiler plate in terms of finding the dependents etc @yuval-k

EItanya · 2025-02-03T15:55:17Z

go/controller/api/v1alpha1/autogenteam_types.go

+
+type SelectorTeamConfig struct {
+	SelectorPrompt string `json:"selectorPrompt"`
+	ModelConfig    string `json:"modelConfig"`


Is this a reference to a ModelSpec? I think this may be overcomplicated for the first go. Agreed that eventually it might be nice to have this defined in one spot, but in 99% of cases defining it inline here is probably easier for the user. What do you think?

Also, will this be the model config used for the whole run, or just for the selector itself?

its a reference to model config
i dont see why users would want to redefine this in every single team cr when the config will be the same when they are using a single llm / api key

EItanya · 2025-02-03T16:02:10Z

go/controller/api/v1alpha1/autogenteam_types.go

+	ModelConfig    string `json:"modelConfig"`
+}
+
+// +kubebuilder:validation:XValidation:message="There must one termination type set",rule="1 == (self.maxMessageTermination != null?1:0) + (self.textMentionTermination != null?1:0) + (self.orTermination != null?1:0)"


I think this API may be a tad overcomplicated, we don't need to fix it now but it may be worth simplifying it in the future. Realistically we can just list the termination conditions, and then have a join_condition or something like that which defaults to or, but can set to and.

it's modeled directly off of autogen. we can always change in the future but i think to keep it simple not overthink / redefine their api with new abstractions

yuval-k · 2025-02-10T16:16:48Z

Any reason we're not starting our controllers off with krt? It will handle a lot of the boiler plate in terms of finding the dependents etc @yuval-k

How many dependencies are we talking about?
My understanding is that we have very few, so my hunch is to stay the course and use controller-runtime.

add page for agents

Implements all 16 review comments from inFocus7's code review to improve code quality, test consistency, and validation reliability for the TLS configuration feature. Changes: 1. Fix CEL validation syntax (comment kagent-dev#16 - CRITICAL) - Replace != "" with size(field) > 0 for non-empty checks - Replace == "" with size(field) == 0 for empty checks - Fixes validation syntax errors that blocked CRD deployment 2. Remove task tracking comments (comments #1, kagent-dev#13, kagent-dev#14, kagent-dev#15) - Remove "(Task X.Y)" references from test docstrings - Remove obsolete implementation notes about env vars vs agent config - Remove test_openai_client_tls_parameters_override_environment (obsolete) 3. Fix copyright headers (comment #3) - Replace incorrect "Google LLC" copyright with Kagent project copyright - Apply consistent headers across test_ssl.py, test_tls_e2e.py, test_tls_integration.py 4. Migrate Go tests to testify (comments kagent-dev#5, kagent-dev#6) - Add testify/assert and testify/require imports - Replace manual error checks with testify assertions - Add envVarToMapHelper() for O(n) environment variable validation 5. Add golden tests for TLS scenarios (comment kagent-dev#12) - Create tls-with-custom-ca.yaml input - Create tls-with-disabled-verify.yaml input - Create tls-with-system-cas-disabled.yaml input - Generate golden outputs to catch TLS mounting regressions 6. Improve Python test quality (comments #2, kagent-dev#4, kagent-dev#9) - Remove redundant test case from test_ssl.py - Add test_e2e_openai_client_fails_without_custom_ca (negative test) - Simplify E2E_TEST_SUMMARY.md (72% reduction, remove task references) 7. Use OpenAI SDK's DefaultAsyncHttpxClient (comments kagent-dev#7, kagent-dev#8) - Replace custom httpx.AsyncClient with DefaultAsyncHttpxClient - Preserves OpenAI SDK defaults for timeout, pooling, and redirects - Add tests to verify SDK defaults are maintained 8. Fix documentation links (comment kagent-dev#10) - Update broken troubleshooting links to https://kagent.dev/docs 9. Document future enhancement (comment kagent-dev#11) - Created GitHub issue kagent-dev#1091 for automatic agent redeployment on secret changes Test results: - All Go tests pass (11 golden tests including 3 new TLS scenarios) - All Python tests pass (15 tests including 2 new tests) - CRD validation working correctly with proper error messages 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Implements all 16 review comments from inFocus7's code review to improve code quality, test consistency, and validation reliability for the TLS configuration feature. Changes: 1. Fix CEL validation syntax (comment kagent-dev#16 - CRITICAL) - Replace != "" with size(field) > 0 for non-empty checks - Replace == "" with size(field) == 0 for empty checks - Fixes validation syntax errors that blocked CRD deployment 2. Remove task tracking comments (comments #1, kagent-dev#13, kagent-dev#14, kagent-dev#15) - Remove "(Task X.Y)" references from test docstrings - Remove obsolete implementation notes about env vars vs agent config - Remove test_openai_client_tls_parameters_override_environment (obsolete) 3. Fix copyright headers (comment #3) - Replace incorrect "Google LLC" copyright with Kagent project copyright - Apply consistent headers across test_ssl.py, test_tls_e2e.py, test_tls_integration.py 4. Migrate Go tests to testify (comments kagent-dev#5, kagent-dev#6) - Add testify/assert and testify/require imports - Replace manual error checks with testify assertions - Add envVarToMapHelper() for O(n) environment variable validation 5. Add golden tests for TLS scenarios (comment kagent-dev#12) - Create tls-with-custom-ca.yaml input - Create tls-with-disabled-verify.yaml input - Create tls-with-system-cas-disabled.yaml input - Generate golden outputs to catch TLS mounting regressions 6. Improve Python test quality (comments #2, kagent-dev#4, kagent-dev#9) - Remove redundant test case from test_ssl.py - Add test_e2e_openai_client_fails_without_custom_ca (negative test) - Simplify E2E_TEST_SUMMARY.md (72% reduction, remove task references) 7. Use OpenAI SDK's DefaultAsyncHttpxClient (comments kagent-dev#7, kagent-dev#8) - Replace custom httpx.AsyncClient with DefaultAsyncHttpxClient - Preserves OpenAI SDK defaults for timeout, pooling, and redirects - Add tests to verify SDK defaults are maintained 8. Fix documentation links (comment kagent-dev#10) - Update broken troubleshooting links to https://kagent.dev/docs 9. Document future enhancement (comment kagent-dev#11) - Created GitHub issue kagent-dev#1091 for automatic agent redeployment on secret changes Test results: - All Go tests pass (11 golden tests including 3 new TLS scenarios) - All Python tests pass (15 tests including 2 new tests) - CRD validation working correctly with proper error messages

ilackarms added 4 commits January 28, 2025 10:51

kubebuilder init

069ff78

add autogen api types to kubebuilder

fc6d388

implement translator, cleanup apis

5c979e9

regen

52cd651

yuval-k reviewed Jan 28, 2025

View reviewed changes

npolshakova reviewed Jan 29, 2025

View reviewed changes

npolshakova approved these changes Jan 30, 2025

View reviewed changes

ilackarms added 4 commits January 30, 2025 17:40

wip: translation tweaks, api

a4044f1

Merge branch 'main' into kube-controller

c16576b

move controller

9db5fc5

get test running, working thru translation

333a936

npolshakova approved these changes Jan 31, 2025

View reviewed changes

ilackarms added 5 commits February 3, 2025 09:47

fix api types

801e453

wire up controller, reconciler, and translator

5ca926b

regen

bee82cb

remove unused files

4d04f5c

bump go version

374baa3

EItanya reviewed Feb 3, 2025

View reviewed changes

EItanya force-pushed the main branch from 9906df5 to f723030 Compare February 10, 2025 02:28

yuval-k approved these changes Feb 11, 2025

View reviewed changes

ilackarms merged commit 7121300 into main Feb 11, 2025

EItanya deleted the kube-controller branch March 17, 2025 17:01

mukundkumarjha pushed a commit to mukundkumarjha/kagent that referenced this pull request May 6, 2025

Merge pull request kagent-dev#12 from kagent-dev/agents-page

89e49f4

add page for agents

add Kube controller #12

add Kube controller #12

Uh oh!

Conversation

ilackarms commented Jan 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EItanya left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yuval-k commented Feb 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants