Enable use of postgres in local development #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables PostgreSQL as an optional backing store for the kagent controller in local development environments. It adds a PostgreSQL deployment configuration, updates the Makefile to install it as part of the addon setup, and provides comprehensive documentation on how to use it.
Key Changes:
- Adds PostgreSQL 18 Alpine deployment with ConfigMap, PVC, Deployment, and Service resources
- Updates Makefile
kagent-addon-installtarget to include postgres installation and readiness checks - Adds detailed documentation for postgres usage including configuration, verification, and rollback instructions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| contrib/addons/postgres.yaml | New Kubernetes manifest defining PostgreSQL deployment, service, storage, and configuration for local development |
| Makefile | Updates addon installation target to deploy postgres and wait for readiness; adds context flags to kubectl commands for consistency |
| DEVELOPMENT.md | Adds comprehensive documentation for optional addons including postgres setup, usage examples, and instructions for switching between SQLite and PostgreSQL |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
e3790ba to
03d2246
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
EItanya
approved these changes
Dec 2, 2025
GTRekter
pushed a commit
to GTRekter/kagent
that referenced
this pull request
Dec 4, 2025
Enables local testing using postgres as a backing store for controller. Split out from kagent-dev#1133 (with added docs). --------- Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ivan Porta <porta.ivan@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables local testing using postgres as a backing store for controller.
Split out from #1133 (with added docs).