refactor: add RestoreAt and rename From to At#50
Merged
Conversation
Contributor
Code Metrics Report
Details | | main (7f65bc5) | #50 (73c3ce8) | +/- |
|---------------------|----------------|---------------|-------|
+ | Coverage | 5.8% | 6.1% | +0.2% |
| Files | 10 | 10 | 0 |
| Lines | 407 | 408 | +1 |
+ | Covered | 24 | 25 | +1 |
- | Code to Test Ratio | 1:0.1 | 1:0.1 | -0.1 |
| Code | 942 | 945 | +3 |
- | Test | 108 | 104 | -4 |
+ | Test Execution Time | 11s | 10s | -1s |Code coverage of files in pull request scope (19.6% → 20.3%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the time-based position logic in the
pospackage to improve clarity and testability. The main changes include renaming theFromfunction toAt, introducing a newRestoreAtfunction for restoring positions with a specific reference time, and updating the tests to use these new interfaces and more predictable, fixed times.API improvements and refactoring:
FromtoAtinpos.goto clarify that it creates a position at a specific point in time. [1] [2]RestoreAtto allow restoring aPosfrom serialized data using an explicit reference time, and refactored the originalRestoreto delegate to this new function.Testing improvements:
pos_test.goto use a fixednowtime for deterministic testing, and replaced all test invocations ofFrom/RestorewithAt/RestoreAt. This ensures tests are not dependent on the system clock and improves reliability. [1] [2] [3] [4]