Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Code Metrics Report
Details | | main (a20f34f) | #30 (4d8cf7e) | +/- |
|---------------------|----------------|---------------|-------|
- | Coverage | 6.0% | 5.6% | -0.4% |
| Files | 10 | 10 | 0 |
| Lines | 379 | 405 | +26 |
| Covered | 23 | 23 | 0 |
- | Code to Test Ratio | 1:0.1 | 1:0.1 | -0.1 |
| Code | 901 | 939 | +38 |
| Test | 102 | 102 | 0 |
+ | Test Execution Time | 10s | 2s | -8s |Code coverage of files in pull request scope (0.0% → 0.0%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to input handling and filtering for the
tailor-logtool, both in the CLI and its GitHub Action integration. The changes simplify the configuration of input sources, allowing users to specify patterns for filtering function and pipeline logs more flexibly. The implementation now supports wildcard matching for input sources, and the configuration structure has been streamlined for clarity.Input handling and filtering improvements:
Inputsstruct inconfig.Configwith a flat[]stringslice, simplifying how input sources are specified and used throughout the codebase (config/config.go).--inputflag, defaulting to*, and ensuredworkspace-idis required (cmd/root.go). [1] [2]cmd/ingest.go,cmd/stream.go). [1] [2]Wildcard filtering logic:
github.com/IGLOU-EU/go-wildcard/v2library. Function and pipeline log fetchers now filter logs based on user-specified input patterns (tailor/function.go,tailor/pipeline.go). [1] [2] [3] [4] [5] [6]GitHub Action integration:
inputsparameter to the CLI, enabling pattern-based input filtering in workflows (action.yml). [1] [2]Minor CLI improvements:
cmd/stream.go).