chore: bump expr to v1.17.8 and fix projectRoot for git worktrees by k1LoW · Pull Request #1394 · k1LoW/runn

k1LoW · 2026-02-14T14:50:31Z

Update github.com/expr-lang/expr from v1.17.7 to v1.17.8
Adjust exprtrace test error thresholds for expanded generated.txt
Fix projectRoot() to detect .git as file (worktree) not just directory

- Update github.com/expr-lang/expr from v1.17.7 to v1.17.8 - Adjust exprtrace test error thresholds for expanded generated.txt - Fix projectRoot() to detect .git as file (worktree) not just directory

gemini-code-assist · 2026-02-14T14:50:42Z

Summary of Changes

Hello @k1LoW, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on maintaining dependency hygiene by bumping the expr library to its latest patch version. Concurrently, it addresses a critical issue for developers using Git worktrees by enhancing the project root detection logic. The changes ensure broader compatibility and stability, while also updating test expectations to align with the new library version.

Highlights

Dependency Update: Updated the github.com/expr-lang/expr dependency from version v1.17.7 to v1.17.8.
Test Threshold Adjustment: Adjusted the error thresholds in internal/exprtrace/tracer_test.go to accommodate changes potentially introduced by the expr library update, specifically for runErrors, compileErrors, and equalErrors.
Git Worktree Compatibility: Fixed the projectRoot() function in result.go to correctly identify the project root when working within a Git worktree, by checking if the .git entry is a regular file (as it is in worktrees) in addition to being a directory.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

go.mod
- Updated github.com/expr-lang/expr to v1.17.8.
go.sum
- Updated checksums for github.com/expr-lang/expr v1.17.8.
internal/exprtrace/tracer_test.go
- Increased the acceptable error thresholds for runErrors, compileErrors, and equalErrors in Test_ExprOfficialGeneratedExamples.
result.go
- Modified projectRoot() to check if .git is a regular file (for worktrees) or a directory when determining the project root.

Activity

No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request successfully updates the expr dependency to v1.17.8 and correctly adapts the projectRoot function to support git worktrees by checking if .git is a file. The changes are logical and well-implemented. My only suggestion is regarding the test file internal/exprtrace/tracer_test.go, where I've recommended replacing magic numbers for error thresholds with named constants to improve code clarity and maintainability. Overall, this is a good set of changes.

internal/exprtrace/tracer_test.go

github-actions · 2026-02-14T14:54:52Z

BenchmarkManyRunbooks-4

	main (-)	#1394 (7332cf1)	+/-
Number of iterations	1	1	0
Nanoseconds per iteration	4,052,426,735 ns/op	4,000,551,499 ns/op	-51,875,236 ns/op
Bytes allocated per iteration	1,381,590,056 B/op	1,381,799,032 B/op	208,976 B/op
Allocs per iteration	19,288,557 allocs/op	19,288,958 allocs/op	401 allocs/op

Metadata

	main (-)	#1394 (7332cf1)
goos	linux	linux
goarch	amd64	amd64
pkg	github.com/k1LoW/runn	github.com/k1LoW/runn
cpu	AMD EPYC 7763 64-Core Processor	AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

	main (-)	#1394 (7332cf1)	+/-
Number of iterations	1	1	0
Nanoseconds per iteration	2,511,081,819 ns/op	2,539,732,162 ns/op	28,650,343 ns/op
Bytes allocated per iteration	1,280,153,056 B/op	1,279,534,360 B/op	-618,696 B/op
Allocs per iteration	18,647,505 allocs/op	18,646,937 allocs/op	-568 allocs/op

Metadata

	main (-)	#1394 (7332cf1)
goos	linux	linux
goarch	amd64	amd64
pkg	github.com/k1LoW/runn	github.com/k1LoW/runn
cpu	AMD EPYC 7763 64-Core Processor	AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

	main (-)	#1394 (7332cf1)	+/-
Number of iterations	21	21	0
Nanoseconds per iteration	49,923,568 ns/op	49,073,518 ns/op	-850,050 ns/op
Bytes allocated per iteration	23,098,766 B/op	23,054,926 B/op	-43,840 B/op
Allocs per iteration	186,875 allocs/op	186,840 allocs/op	-35 allocs/op

Metadata

	main (-)	#1394 (7332cf1)
goos	linux	linux
goarch	amd64	amd64
pkg	github.com/k1LoW/runn	github.com/k1LoW/runn
cpu	AMD EPYC 7763 64-Core Processor	AMD EPYC 7763 64-Core Processor

Reported by octocov

github-actions · 2026-02-14T14:58:16Z

Code Metrics Report

	main (ae369fd)	#1394 (7332cf1)	+/-
Coverage	60.3%	60.3%	+0.0%
Code to Test Ratio	1:0.8	1:0.8	-0.1
Test Execution Time	7m8s	7m25s	+17s

Details

  |                     | main (ae369fd) | #1394 (7332cf1) |  +/-  |
  |---------------------|----------------|-----------------|-------|
+ | Coverage            |          60.3% |           60.3% | +0.0% |
  |   Files             |             81 |              81 |     0 |
  |   Lines             |           9244 |            9247 |    +3 |
+ |   Covered           |           5577 |            5579 |    +2 |
- | Code to Test Ratio  |          1:0.8 |           1:0.8 |  -0.1 |
  |   Code              |          17295 |           17299 |    +4 |
  |   Test              |          14395 |           14395 |     0 |
- | Test Execution Time |           7m8s |           7m25s |  +17s |

Code coverage of files in pull request scope (67.7% → 67.7%)

Files	Coverage	+/-	Status
internal/expr/expr.go	65.2%	-0.8%	affected
result.go	70.2%	+0.6%	modified

Reported by octocov

chore: bump expr to v1.17.8 and fix projectRoot for git worktrees

ccfed52

- Update github.com/expr-lang/expr from v1.17.7 to v1.17.8 - Adjust exprtrace test error thresholds for expanded generated.txt - Fix projectRoot() to detect .git as file (worktree) not just directory

k1LoW self-assigned this Feb 14, 2026

gemini-code-assist bot reviewed Feb 14, 2026

View reviewed changes

internal/exprtrace/tracer_test.go Show resolved Hide resolved

k1LoW merged commit 5e0f6fd into main Feb 14, 2026
14 of 15 checks passed

k1LoW deleted the update-expr branch February 14, 2026 15:01

github-actions bot mentioned this pull request Feb 14, 2026

Release for v1.3.1 #1379

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: bump expr to v1.17.8 and fix projectRoot for git worktrees#1394

chore: bump expr to v1.17.8 and fix projectRoot for git worktrees#1394
k1LoW merged 1 commit intomainfrom
update-expr

k1LoW commented Feb 14, 2026

Uh oh!

gemini-code-assist bot commented Feb 14, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Feb 14, 2026

Uh oh!

github-actions bot commented Feb 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

k1LoW commented Feb 14, 2026

Uh oh!

gemini-code-assist bot commented Feb 14, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

github-actions bot commented Feb 14, 2026

BenchmarkManyRunbooks-4

BenchmarkOpenAPI3-4

BenchmarkSingleRunbook-4

Uh oh!

github-actions bot commented Feb 14, 2026

Code Metrics Report

Code coverage of files in pull request scope (67.7% → 67.7%)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant