feat: expand curl data file support#1355
Merged
k1LoW merged 9 commits intok1LoW:mainfrom Nov 22, 2025
Merged
Conversation
added 9 commits
November 7, 2025 00:03
Owner
|
@yoRyuuuuu GERAT WORK!!!! |
Owner
|
I have a consultation. After merging this implementation, is it okay for me to backport it to https://github.com/k1LoW/curlreq? |
Author
|
Thanks for the review! Yes, it's okay to backport this to curlreq after this PR is merged. |
Merged
k1LoW
added a commit
to k1LoW/curlreq
that referenced
this pull request
Nov 22, 2025
backport from k1LoW/runn#1355
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements part of #1296
Approach
expandCurlDataFilesrecognizes the@filesyntax in data parameters and expands its content.It supports both separated parameters (
-d @file,--data @file, etc.) and attached parameters (-d@file, --data=@file, etc.).Testing
Added unit tests for
expandCurlDataFiles.Example run
We generated a runbook from the curl command below and confirmed that the @file payload was expanded as exptected.
atom-feed.xml
Notes
--data-urlencodesupport is still out of scope.If you think
--data-urlencodeshould be covered as well, please let me know and I'll tackle it in a follow-up PR.