Conversation
added 5 commits
January 15, 2016 11:00
Also make a couple of small changes to the README to switch from the word 'demo' to 'example'.
I'll also update the README.md in a second pass.
That way they will be automatically included in the base outrigger image as examples/elastic-newstracker/*.juttle.
Update the instructions to assume the in-container examples that are now provided by the base outrigger container. I'm going to add an examples/README.md that talks about the in-container examples and how you can map over them by docker volume mapping instructions.
Add a top-level README.md that talks about how we use docker-compose to run an outrigger and linked backend containers and map a config file in juttle-config.json into the outrigger container. This also contains a known problems section with some gotchas I ran into. Also add a top level index.juttle that points into the various subdirectories. This required changing how we copy files into the container so we only copy the juttle files and not everything. Rework the various READMEs to assume the above docker-compose instance. They now only talk about any additional .yml file necessary, any additions to juttle-config.json, and describe the juttle programs. In a later PR, I'll try to tackle the problem of elasticsearch always being populated from scratch every time you run docker-compose run. This is in pretty good shape now so I'd like to get it merged.
Collaborator
|
I stepped through the examples successfully, made small updates to the README, and filed one issue for an example that broke: #83 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the individual checkins, but generally:
Move elasticsearch and twitter programs from demos to examples.
Use a single docker-compose configuration to run one or more of these examples, which is extended if necessary based on the backends you want to use.
Make all juttle programs below examples available in the base outrigger container so it can be entirely run without a git checkout.
@dmehra wanna go through the examples to see if they make sense?
@demmer I believe this is the layout we agreed on, supporting both built-in examples as well as a wholesale override of /examples into the container if you want to edit them locally.
I didn't yet set up a preloaded version of the news data--I'll work on that in a subsequent PR.
This fixes #20. I'll let #15 to continue to track a more general checklist of demos we want to add.